Skip to content

compilers: fix clang-cl cross without setting many args on cc #15367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mochaaP wants to merge 2 commits into
base: master
Choose a base branch
from
Open

compilers: fix clang-cl cross without setting many args on cc #15367

mochaaP wants to merge 2 commits into from
+12 −8

Conversation

@mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Dec 9, 2025 •
edited
Loading

See the expanded commit messages for explanations.

Before:

[binaries]
c = ['clang-cl', '--target=' + target, '-fuse-ld=lld', '/winsysroot', root]
cpp = ['clang-cl', '--target=' + target, '-fuse-ld=lld', '/winsysroot', root]
# c_ld not set
# cpp_ld not set

After:

[binaries]
c = ['clang-cl', '--target=' + target]
cpp = ['clang-cl', '--target=' + target]
c_ld = 'lld-link'
cpp_ld = 'lld-link'

The detect_vs_dep_prefix change needs more testing. I tested this on:

  • msvc-wine's wrapper
  • native windows msvc
  • clang-cl on linux

@mochaaP
compilers: clike: move -fuse-ld= to compiler args
929100c 
normal compilers does not rely on the position of this argument,
but MSVC-like compilers treat `/link` and any argument after that
as linker arguments. MSVC-like compiler's linker_to_compiler_args
inject `/link` before largs, resulting it being forwarded to link.exe
not the compiler driver.

fixes cross compiling with cc = clang-cl and c_ld = lld-link.
@mochaaP
ninjabackend: msvc: make detect_vs_dep_prefix independent of stdlib
bd3e854 
this function does not pass enough args from the compiler object to find
windows sdk without relying on environment variables.
including a file from the same directory removes the dependency on stdlib.
@mochaaP mochaaP force-pushed the mochaa/clang-cl-cross branch from da492cb to bd3e854 Compare December 9, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbaker dcbaker Awaiting requested review from dcbaker dcbaker is a code owner

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mochaaP