Skip to content

[logging] monarch logs do not go to stderr #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[logging] monarch logs do not go to stderr #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e996c66
[logging] monarch logs do not go to stderr
zdevito Nov 6, 2025
787f66a
Update on "[logging] monarch logs do not go to stderr"
zdevito Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions hyperactor_mesh/src/v1/host_mesh/mesh_agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,17 @@ impl Actor for HostMeshAgent {
type Params = HostAgentMode;

async fn new(host: HostAgentMode) -> anyhow::Result<Self> {
if let HostAgentMode::Process(_) = host {
let (directory, file) = hyperactor_telemetry::log_file_path(
hyperactor_telemetry::env::Env::current(),
None,
)
.unwrap();
eprintln!(
"Monarch internal logs are being written to {}/{}.log",
directory, file
);
}
Ok(Self {
host: Some(host),
created: HashMap::new(),
Expand Down
27 changes: 0 additions & 27 deletions hyperactor_telemetry/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ pub const DISABLE_SQLITE_TRACING: &str = "DISABLE_SQLITE_TRACING";
/// Environment variable constants
// Log level (debug, info, warn, error, critical) to capture for Monarch traces on dedicated log file (changes based on environment, see `log_file_path`).
const MONARCH_FILE_LOG_ENV: &str = "MONARCH_FILE_LOG";
// Log level (debug, info, warn, error, critical) to capture for Monarch traces on stderr.
const MONARCH_STDERR_LOG_ENV: &str = "MONARCH_STDERR_LOG";

pub const MAST_HPC_JOB_NAME_ENV: &str = "MAST_HPC_JOB_NAME";

Expand Down Expand Up @@ -600,29 +598,6 @@ pub fn initialize_logging_with_log_prefix(
.with_target("opentelemetry", LevelFilter::OFF), // otel has some log span under debug that we don't care about
);

let stderr_log_level = match env::Env::current() {
env::Env::Local => LOG_LEVEL_ERROR,
env::Env::MastEmulator => LOG_LEVEL_INFO,
env::Env::Mast => LOG_LEVEL_ERROR,
env::Env::Test => LOG_LEVEL_DEBUG,
};
let stderr_layer = fmt::Layer::default()
.with_writer(std::io::stderr)
.event_format(PrefixedFormatter::new(prefix_env_var))
.fmt_fields(GlogFields::default().compact())
.with_ansi(std::io::stderr().is_terminal())
.with_filter(
Targets::new()
.with_default(LevelFilter::from_level(
tracing::Level::from_str(
&std::env::var(MONARCH_STDERR_LOG_ENV)
.unwrap_or(stderr_log_level.to_string()),
)
.expect("Invalid log level"),
))
.with_target("opentelemetry", LevelFilter::OFF), // otel has some log span under debug that we don't care about
);

use tracing_subscriber::Registry;
use tracing_subscriber::layer::SubscriberExt;
use tracing_subscriber::util::SubscriberInitExt;
Expand All @@ -645,7 +620,6 @@ pub fn initialize_logging_with_log_prefix(
None
})
.with(file_layer)
.with(stderr_layer)
.with(if is_layer_enabled(DISABLE_RECORDER_TRACING) {
Some(recorder().layer())
} else {
Expand Down Expand Up @@ -680,7 +654,6 @@ pub fn initialize_logging_with_log_prefix(
{
if let Err(err) = Registry::default()
.with(file_layer)
.with(stderr_layer)
.with(
if std::env::var(DISABLE_RECORDER_TRACING).unwrap_or_default() != "1" {
Some(recorder().layer())
Expand Down
Loading