Skip to content

fix a flaky test #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

fix a flaky test #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/tests/_monarch/test_mailbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

# pyre-strict

import asyncio
import pickle
from typing import (
Any,
Expand All @@ -29,10 +28,9 @@
PythonMessageKind,
)
from monarch._rust_bindings.monarch_hyperactor.pytokio import PythonTask
from monarch._src.actor.future import Future

if TYPE_CHECKING:
from monarch._rust_bindings.monarch_hyperactor.actor import CallMethod, PortProtocol
from monarch._rust_bindings.monarch_hyperactor.actor import PortProtocol


from monarch._rust_bindings.monarch_hyperactor.alloc import AllocConstraints, AllocSpec
Expand Down Expand Up @@ -202,3 +200,6 @@ def my_reduce(state: str, update: str) -> str:
messge = await receiver.recv_task().with_timeout(seconds=5)
value = pickle.loads(messge.message)
assert "[reduced](start+msg0)" in value

# Note: occasionally test would hang without this stop
await proc_mesh.stop_nonblocking()