Add InMemoryReader to expose otel counter information on demand #782
+171
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79658641 |
benjipelletier
force-pushed
the
export-D79658641
branch
from
5580658 to
03d4c99
Compare
benjipelletier
added a commit
to benjipelletier/monarch-1
that referenced
this pull request
Aug 7, 2025
…-pytorch#782) Summary: Add a new otel reader type `InMemoryReader` * impls `ManualReader` and stores global ManualReader instance so we can get metrics during hyperactor program runs. * provides getters to cumulative counters. Will add more metrics later *‼️ Uses cumulative temporality so metrics are stored in the SDK rather than in hyperactor. This might be something we iterate on if collection and transforming to a hashmap each time is too costly * also changes macros in lib.rs to use $crate eliothedeman Reviewed By: eliothedeman Differential Revision: D79658641
|
This pull request was exported from Phabricator. Differential Revision: D79658641 |
benjipelletier
force-pushed
the
export-D79658641
branch
from
03d4c99 to
4a228dd
Compare
benjipelletier
added a commit
to benjipelletier/monarch-1
that referenced
this pull request
Aug 8, 2025
…-pytorch#782) Summary: Add a new otel reader type `InMemoryReader` * impls `ManualReader` and stores global ManualReader instance so we can get metrics during hyperactor program runs. * provides getters to cumulative counters. Will add more metrics later *‼️ Uses cumulative temporality so metrics are stored in the SDK rather than in hyperactor. This might be something we iterate on if collection and transforming to a hashmap each time is too costly * also changes macros in lib.rs to use $crate eliothedeman Reviewed By: eliothedeman Differential Revision: D79658641
|
This pull request was exported from Phabricator. Differential Revision: D79658641 |
…-pytorch#782) Summary: Add a new otel reader type `InMemoryReader` * impls `ManualReader` and stores global ManualReader instance so we can get metrics during hyperactor program runs. * provides getters to cumulative counters. Will add more metrics later *‼️ Uses cumulative temporality so metrics are stored in the SDK rather than in hyperactor. This might be something we iterate on if collection and transforming to a hashmap each time is too costly * also changes macros in lib.rs to use $crate eliothedeman Reviewed By: eliothedeman Differential Revision: D79658641
benjipelletier
force-pushed
the
export-D79658641
branch
from
4a228dd to
7fc5a76
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79658641 |
benjipelletier
added a commit
to benjipelletier/monarch-1
that referenced
this pull request
Aug 8, 2025
…-pytorch#782) Summary: Add a new otel reader type `InMemoryReader` * impls `ManualReader` and stores global ManualReader instance so we can get metrics during hyperactor program runs. * provides getters to cumulative counters. Will add more metrics later *‼️ Uses cumulative temporality so metrics are stored in the SDK rather than in hyperactor. This might be something we iterate on if collection and transforming to a hashmap each time is too costly * also changes macros in lib.rs to use $crate eliothedeman Reviewed By: eliothedeman Differential Revision: D79658641
|
This pull request has been merged in d905ba2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a new otel reader type
InMemoryReaderimpls
ManualReaderand stores global ManualReader instance so we can get metrics during hyperactor program runs.provides getters to cumulative counters. Will add more metrics later
also changes macros in lib.rs to use $crate eliothedeman
Reviewed By: eliothedeman
Differential Revision: D79658641