[hyperactor] simplify supervision propagation; unhandled events always cause failure #784
+213
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s cause failure Currently (local) supervision can propagate events without also killing an intermediate actor. This is 1) wrong; and 2) complicated. Instead, we treat an unhandled supervision event as an actor failure, and then reduce the propagation paths to one: that of an actor failing. In order to retain accurate attribution, we add a "caused_by" field to the actor supervision events. Differential Revision: [D79702385](https://our.internmc.facebook.com/intern/diff/D79702385/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79702385/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Aug 6, 2025
…s cause failure Currently (local) supervision can propagate events without also killing an intermediate actor. This is 1) wrong; and 2) complicated. Instead, we treat an unhandled supervision event as an actor failure, and then reduce the propagation paths to one: that of an actor failing. In order to retain accurate attribution, we add a "caused_by" field to the actor supervision events. Differential Revision: [D79702385](https://our.internmc.facebook.com/intern/diff/D79702385/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79702385/)! ghstack-source-id: 301209925 Pull Request resolved: #784
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79702385 |
…vents always cause failure" Currently (local) supervision can propagate events without also killing an intermediate actor. This is 1) wrong; and 2) complicated. Instead, we treat an unhandled supervision event as an actor failure, and then reduce the propagation paths to one: that of an actor failing. In order to retain accurate attribution, we add a "caused_by" field to the actor supervision events. Differential Revision: [D79702385](https://our.internmc.facebook.com/intern/diff/D79702385/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79702385/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79702385 |
…vents always cause failure" Currently (local) supervision can propagate events without also killing an intermediate actor. This is 1) wrong; and 2) complicated. Instead, we treat an unhandled supervision event as an actor failure, and then reduce the propagation paths to one: that of an actor failing. In order to retain accurate attribution, we add a "caused_by" field to the actor supervision events. Differential Revision: [D79702385](https://our.internmc.facebook.com/intern/diff/D79702385/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79702385/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79702385 |
…vents always cause failure" Currently (local) supervision can propagate events without also killing an intermediate actor. This is 1) wrong; and 2) complicated. Instead, we treat an unhandled supervision event as an actor failure, and then reduce the propagation paths to one: that of an actor failing. In order to retain accurate attribution, we add a "caused_by" field to the actor supervision events. Differential Revision: [D79702385](https://our.internmc.facebook.com/intern/diff/D79702385/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79702385/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79702385 |
This was referenced Aug 7, 2025
…vents always cause failure" Currently (local) supervision can propagate events without also killing an intermediate actor. This is 1) wrong; and 2) complicated. Instead, we treat an unhandled supervision event as an actor failure, and then reduce the propagation paths to one: that of an actor failing. In order to retain accurate attribution, we add a "caused_by" field to the actor supervision events. Differential Revision: [D79702385](https://our.internmc.facebook.com/intern/diff/D79702385/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D79702385/)! [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D79702385 |
|
This pull request has been merged in b5ecd8f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently (local) supervision can propagate events without also killing an intermediate actor.
This is 1) wrong; and 2) complicated.
Instead, we treat an unhandled supervision event as an actor failure, and then reduce the propagation paths to one: that of an actor failing.
In order to retain accurate attribution, we add a "caused_by" field to the actor supervision events.
Differential Revision: D79702385
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!