Skip to content

Rename RLTrainer to TitanTrainer #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2025
Merged

Rename RLTrainer to TitanTrainer #538

merged 4 commits into from
Nov 7, 2025

Conversation

@allenwang28
Copy link
Contributor

@allenwang28 allenwang28 commented Nov 6, 2025 •
edited
Loading

Renamed the RLTrainer class to TitanTrainer to better reflect its TorchTitan foundation.

Added backward-compatible deprecation warnings for RLTrainer and updated all imports throughout the codebase, including apps, docs, and tests.

We leave the old RLTrainer name still accessible but emit a future deprecation warning.


  # Before
  from forge.actors.trainer import RLTrainer

  # After
  from forge.actors.trainer import TitanTrainer

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 6, 2025
@allenwang28 allenwang28 changed the title [wip] Rename RLTrainer to TitanTrainer Rename RLTrainer to TitanTrainer Nov 7, 2025
@allenwang28 allenwang28 marked this pull request as ready for review November 7, 2025 15:18
@allenwang28 allenwang28 merged commit bb57589 into meta-pytorch:main Nov 7, 2025
10 checks passed
@allenwang28 allenwang28 deleted the titan_trainer branch November 7, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joecummings joecummings joecummings approved these changes

@daniellepintz daniellepintz Awaiting requested review from daniellepintz

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allenwang28 @joecummings