refactor train pipeline config #3433
Closed
+138
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@TroyGarden has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83890174. |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Oct 4, 2025
Summary: Pull Request resolved: meta-pytorch#3433 p# context * continue refactoring the pipeline benchmark * moving the pipeline generation config and function to a new file "test_utils/test_pipeline.py", so they can be used by other test cases * the design logic is to use config to generate each component (tables, pipeline, input, etc.) under the test_utils. * rename the benchmark_base.py to base.py per suggestion from previous diff Differential Revision: D83890174
TroyGarden
force-pushed
the
export-D83890174
branch
from
6ece4ea to
41c4a77
Compare
Summary: Pull Request resolved: meta-pytorch#3433 p# context * continue refactoring the pipeline benchmark * moving the pipeline generation config and function to a new file "test_utils/train_pipeline.py", so they can be used by other test cases * rename the file test_tables.py to table_config.py, the "test_" prefix is redundent. * the design logic is to use config to generate each component (tables, pipeline, input, etc.) under the test_utils. * rename the benchmark_base.py to base.py per suggestion from previous diff Differential Revision: D83890174
TroyGarden
force-pushed
the
export-D83890174
branch
from
41c4a77 to
583859b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
p# context
Differential Revision: D83890174