fix multiple tests. with latest monarch and rdma, ts.put and ts.get only works inside an actor #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
force-pushed
the
export-D86156904
branch
from
64e2126 to
69635a3
Compare
facebook-github-bot
force-pushed
the
export-D86156904
branch
from
69635a3 to
7acdcf9
Compare
facebook-github-bot
force-pushed
the
export-D86156904
branch
from
7acdcf9 to
bc4aeaa
Compare
casteryh
force-pushed
the
export-D86156904
branch
from
bc4aeaa to
7cb2311
Compare
facebook-github-bot
force-pushed
the
export-D86156904
branch
2 times, most recently
from
e03a56b to
bd7ec71
Compare
Summary: Monarch is enforcing the following check. This diff is a fix. ValueError: <class 'torchstore.controller.Controller'> mixes both async and sync endpoints.Synchronous endpoints cannot be mixed with async endpoints because they can cause the asyncio loop to deadlock if they wait.sync: ['get_controller_strategy', 'keys', 'locate_volumes', 'notify_delete', 'notify_put'] async: ['init', 'teardown'] Reviewed By: amirafzali, LucasLLC Differential Revision: D86155590
facebook-github-bot
force-pushed
the
export-D86156904
branch
from
bd7ec71 to
f627fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D86156904