Skip to content

BUCK for tests #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2025
Merged

BUCK for tests #76

merged 3 commits into from
Nov 7, 2025

Conversation

@casteryh
Copy link
Contributor

@casteryh casteryh commented Nov 4, 2025

Summary: automation

Reviewed By: felipemello1

Differential Revision: D86159099

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 4, 2025

@casteryh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86159099.

facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
acba9d7 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
e162f93 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
66d11ee 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
b9193fb 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
@facebook-github-bot facebook-github-bot force-pushed the export-D86159099 branch 2 times, most recently from b9193fb to 99987ea Compare November 5, 2025 01:43
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
99987ea 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 17.64706% with 84 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@9dd276c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tests/test_tensor_slice.py 0.00% 53 Missing ⚠️
tests/test_keys.py 27.27% 16 Missing ⚠️
tests/test_store.py 41.17% 10 Missing ⚠️
tests/test_resharding_ext.py 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage        ?   52.04%           
=======================================
  Files           ?       23           
  Lines           ?     1885           
  Branches        ?        0           
=======================================
  Hits            ?      981           
  Misses          ?      904           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
7bc8a31 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
casteryh added a commit that referenced this pull request Nov 5, 2025
@casteryh @meta-codesync
BUCK for tests (#76)
7003a1c 
Summary:
Pull Request resolved: #76

automation

Reviewed By: felipemello1

Differential Revision: D86159099
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
e914133 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
@casteryh @facebook-github-bot
fix controller endpoint (#74)
a5e6c04 
Summary:

Monarch is enforcing the following check. This diff is a fix.

ValueError: <class 'torchstore.controller.Controller'> mixes both async and sync endpoints.Synchronous endpoints cannot be mixed with async endpoints because they can cause the asyncio loop to deadlock if they wait.sync: ['get_controller_strategy', 'keys', 'locate_volumes', 'notify_delete', 'notify_put'] async: ['init', 'teardown']

Reviewed By: amirafzali, LucasLLC

Differential Revision: D86155590
@casteryh @facebook-github-bot
fix multiple tests. with latest monarch and rdma, ts.put and ts.get o…
fbb0ac2 
…nly works inside an actor (#75)

Summary: Pull Request resolved: #75

Reviewed By: LucasLLC, amirafzali

Differential Revision: D86156904
@casteryh @facebook-github-bot
BUCK for tests (#76)
6b80c5a 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
facebook-github-bot pushed a commit that referenced this pull request Nov 5, 2025
@casteryh @facebook-github-bot
BUCK for tests (#76)
038889d 
Summary:

automation

Reviewed By: felipemello1

Differential Revision: D86159099
@facebook-github-bot facebook-github-bot force-pushed the export-D86159099 branch 2 times, most recently from 038889d to 6b80c5a Compare November 5, 2025 22:05
@meta-codesync meta-codesync bot merged commit 12cd65b into main Nov 7, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felipemello1 felipemello1 felipemello1 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@casteryh @codecov-commenter @felipemello1