Skip to content

Conversation

@kiukchung
Copy link
Contributor

@kiukchung kiukchung commented Oct 16, 2025

yesterday (10/15/2025) there was a new release of torch, torchvision, and torchtext.

Usually these three libs are released on the same day and need to be on matching releases to work together. Our dev-requirements.txt had torchvision pinned to 0.23.0 but torch pinned (loosely) to >=2.7.0. Therefore, as of 10/15, the CI installed torch-2.9.0 and torchvision-0.23.0 (not 0.24.0) hence causing a segfault.

This PR unpins torch, torchvision, and torchtext so that we grab the latest versions of all three packages.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.69%. Comparing base (79e14da) to head (6a49227).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   91.65%   91.69%   +0.04%     
==========================================
  Files          83       83              
  Lines        6483     6539      +56     
==========================================
+ Hits         5942     5996      +54     
- Misses        541      543       +2     
Flag Coverage Δ
unittests 91.69% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@AbishekS AbishekS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

…ttests due to incompatible version of torchvision/text and torch
Copy link
Contributor

@AbishekS AbishekS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiukchung kiukchung merged commit 426b91a into main Oct 16, 2025
19 checks passed
@kiukchung kiukchung deleted the kiuk-dev branch October 16, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants