-
Notifications
You must be signed in to change notification settings - Fork 39
Fix issue with app path and namespace #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix issue with app path and namespace #64
Conversation
2bb7c53
to
bfcc23f
Compare
bfcc23f
to
c51d53b
Compare
…leTrait and CustomModuleTrait
…ty in Livewire components
c51d53b
to
b91925f
Compare
@solomon-ochepa Sorry for the delay. Thanks for your PR. There is a lot of refactored code, and it's great. Also, I checked, and I am getting some errors. Errors:
It seems not to register the Livewire component, only registers as a Volt component. My component path:
It's registering - "app/App\Livewire" directory. But this directory does not exist. Existing directory is - "app/Livewire". So, without a volt, it's not working. The component was not found. Could you explain the "app" namespace things, please? Would you like to support just the "app" or the "src" namespace for components? It will be registered by the modules config - "app_path"? I checked with: Laravel: 12 |
This is a complementary branch for the laravel-modules package. You must checkout to the same branch on both repositories - I named both branches the same. |
Please let me know if you need more clarification. This is a complimentary PR for You must check out both branches simultaneously. |
Summary
Resolve issues with the
app/
path by supporting both default and custom names while ensuring proper namespace conversion.Description
The
app/
path was previously removed due to multiple issues. This task involves reintroducing support for it while ensuring:app/
) and custom paths (src/
,/
).Acceptance Criteria:
app/
path works with both default and custom configurations.Tests (
PathNamespaceTest
)Let me know if you want any modifications! 🚀
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores
.gitignore
to exclude common build, dependency, and system files.Style