Address scenarios with close page-media relations #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this pull request with this nice feature! I've just tested this a tiny bit and while it looks awesome, I noticed a couple of small regressions compared to the current UI:
|
|
Sorry for the confusing pushes. I first wanted to merge this directly, manually due to the merge conflicts but then I saw the problems mentioned in the previous comment. I then tried pushing the merge to this branch but somehow GitHub then displayed all commits from the master branch in this PR (maybe because the parents were in the wrong order as I merged the media branch into the master branch). To clean this up again I've now force-pushed it to the previous state with the merge conflict. |
A new checkbox allows to move referenced page media along with a page rename. This happens only if * the checkbox is ticked * the page actually moves to a new namespace * the page was not in the root namespace * the referenced media is in the same namespace as the page # Conflicts: # action/rename.php
This rewrite drops all dependencies on jQuery for the tree manager and uses modern JavaScript for the drag'n'drop operations. It introduces the posibility to view the tree as a merged tree of page and media namespaces (similar to what we do in the ACL manager). This merged view is often advantageous in wikis where both trees are very similar. A default view can be set in the configuration but users can switch between the views on a case by case basis. This does not change any functionality in any of the other scripts or in the way how the move is executed. It's a GUI refresh only. Other parts of the plugin could use a GUI refresh as well (eg. use the same SVG based icons and drop jQuery dependencies).
The duplicate message now displays a full ID including the namespace, so the string had to be adjusted. This removes it from all language files to have translators retranslate it. � Conflicts: � lang/cs/lang.php � lang/zh/lang.php
We let the browser throw an error instead of trying to figure it out ourself.
It's fine to have a page and a namespace named the same. Or a media file and a page named the same.
|
I rebased the branch on current master. I will have a look at the issues later. Thanks for having a look! |
* avoid moves to the same destination in admin interface * avoid renames to self in tree manager * avoid moves where items have been moved back to the original destination in tree manager Note: all of this is mostly cosmetics. Self-moves are also detected during plan execution, trigger an error and can be skipped.
|
The issues should be addressed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people use media files in close relation with the pages. Eg. media is rarely reused across different pages and rarely across namespaces. Usually media files are located in namespaces named exactly like the namespace of the page they are used in. In this scenario it is desirable to move media together with the page. (See #222, #269, #273 and possibly others).
This PR addresses this scenario in two ways: