Skip to content

Remove redundant get() methods from "Config" classes #6145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant get() methods from "Config" classes #6145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,11 @@ subprojects {
ignoreMissingClasses = true
includeSynthetic = true

classExcludes = []
classExcludes = [
'io.micrometer.elastic.ElasticConfig',
'io.micrometer.ganglia.GangliaConfig',
'io.micrometer.graphite.GraphiteConfig'
]
compatibilityChangeExcludes = [ "METHOD_NEW_DEFAULT" ]

packageExcludes = ['io.micrometer.shaded.*', 'io.micrometer.statsd.internal']
Expand Down
8 changes: 0 additions & 8 deletions ...ations/micrometer-registry-elastic/src/main/java/io/micrometer/elastic/ElasticConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ public interface ElasticConfig extends StepRegistryConfig {
*/
ElasticConfig DEFAULT = k -> null;

/**
* Get the value associated with a key.
* @param key Key to look up in the config.
* @return Value for the key or null if no key is present.
*/
@Nullable
String get(String key);

/**
* Property prefix to prepend to configuration names.
* @return property prefix
Expand Down
8 changes: 0 additions & 8 deletions ...ations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ public interface GangliaConfig extends StepRegistryConfig {
*/
GangliaConfig DEFAULT = k -> null;

/**
* Get the value associated with a key.
* @param key Key to lookup in the config.
* @return Value for the key or null if no key is present.
*/
@Nullable
String get(String key);

/**
* @return Property prefix to prepend to configuration names.
*/
Expand Down
9 changes: 0 additions & 9 deletions ...ons/micrometer-registry-graphite/src/main/java/io/micrometer/graphite/GraphiteConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
package io.micrometer.graphite;

import io.micrometer.common.lang.Nullable;
import io.micrometer.core.instrument.config.validate.Validated;
import io.micrometer.core.instrument.dropwizard.DropwizardConfig;

Expand All @@ -36,14 +35,6 @@ public interface GraphiteConfig extends DropwizardConfig {
*/
GraphiteConfig DEFAULT = k -> null;

/**
* Get the value associated with a key.
* @param key Key to lookup in the config.
* @return Value for the key or null if no key is present.
*/
@Nullable
String get(String key);

/**
* @return Property prefix to prepend to configuration names.
*/
Expand Down