Conversation
sfkamath
force-pushed
the
feat/5.1.x-tck-publish
branch
from
September 14, 2026 00:12
1e7bd38 to
82c0e1c
Compare
Contributor
First one caused by change in
|
Contributor
|
Should this target 5.2.x ? |
Contributor
|
After this, |
micronaut-data-tck, micronaut-data-document-tck, and micronaut-jakarta-data-tck:micronaut-support have never had a Maven publication, so a downstream repository could never resolve them and had to be built inside micronaut-data's own composite build instead. Add a plain maven-publish publication to each. The support module gets an explicit artifactId since its default (derived from the leaf project name) collides with other "support" modules in the build. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- test-annotation-processor-java no longer uses the (now published) data-tck plugin - rename the Jakarta Data TCK support project to jakarta-data-support-tck so the BOM filter excludes it - drop runtime logback from the support module, move servlet API version into the catalog - expose dependencies whose types appear in the TCK spec API as api - disable binary compatibility checks for the TCK artifacts
dstepanov
force-pushed
the
feat/5.1.x-tck-publish
branch
from
September 24, 2026 12:03
ad5ca75 to
ff10994
Compare
- add the standard license header to TCK sources (spotless) - keep the Eclipse Foundation header on TCKArchiveProcessor, excluded from spotless - disable checkstyle for the TCK artifacts, they are test fixtures - skip documentation for the Jakarta Data TCK support module
Restore the data-tck convention plugin to its non-publishing form and add a data-tck-module plugin that published TCK modules apply explicitly.
radovanradic
approved these changes
Sep 24, 2026
radovanradic
force-pushed
the
feat/5.1.x-tck-publish
branch
from
September 24, 2026 20:11
514a8ec to
3cec9d9
Compare
…ut-data into pr-4046 # Conflicts: # gradle/libs.versions.toml
Publishing data-tck applies the module plugin, so its Groovy compiler daemons (1048m, -Dgroovy.parameters) accept every Groovy compile in the build. The examples then reused daemons that had already compiled all module test sources and ran out of heap. A marker system property keeps the examples in a separate daemon.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by micronaut-data-nitrite to run the Jakarta Data TCK against its own store. Applies
io.micronaut.build.internal.module(instead ofjava-base) toio.micronaut.build.internal.data-tck.gradleandjakarta-data-tck/support/build.gradle, matching every other released module.🤖 Generated with Claude Code