Fix 5.2.x CI after the dependency upgrades - #4061
Merged
Merged
Conversation
MariaDB Connector/J 3.5.10 (micronaut-sql 7.2.0) enforces read-only transactions, expect the failure like the MySQL and Postgres specs. Test resources 4.3.0 checks the Oracle container readiness over JDBC, add the driver to the test resources service of the sessionless booking example, which does not infer its classpath.
Micronaut 5.2.5 copies the annotations of every type allowed reflective access onto the generated Java source, including the internal @Datamethod of the repositories, whose generic interceptor class literal does not compile. Only allow the JPA types Hibernate reads reflectively. The copy is fixed in Micronaut 5.2.6 (micronaut-core#13401).
radovanradic
approved these changes
Sep 24, 2026
|
Contributor
|
Picked these changes in branch that is merge into 5.2.x and it did not need hiberate python changes from here since it uses core 5.2.6 so this PR might not be needed. |
Member
I reverted it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failures on
5.2.xsince the dependency upgrades (they also fail every PR, e.g. #4060).MariaTransactionsSpec: MariaDB Connector/J 3.5.10 (from micronaut-sql 7.2.0, was 3.5.9) now rejects writes in a read-only transaction (Cannot execute statement in a READ ONLY transaction). The spec now expects the failure, likeMySqlTransactionsSpecandPostgresTransactionsSpec.jdbc-sessionless-transaction-booking: test resources 4.3.0 waits for the Oracle container over JDBC (NoDriverFoundException: Could not get Driver). The example setsinferClasspath = false, soojdbc11is added totestResourcesService, as the other Oracle modules do.hibernate-example-python,hibernate-reactive-example-python): Micronaut 5.2.5 copies the annotations of every type allowed reflective access onto the generated Java source (micronaut-core#13338). WithallowReflection=example.*that includes the repositories' internal@DataMethod, rendered asFindAllInterceptor<Object, Object>.class, which doesn't compile. The pattern now lists only the JPA types Hibernate reads reflectively. The copy is fixed in core 5.2.6 (micronaut-core#13401), which isn't on Maven Central yet; once it is,example.*can come back.Verified locally:
MariaTransactionsSpec44/44,BookingServiceTest3/3, the two hibernate Python examples 12/12 and 2/2 with-Ppython-ci. The Python failure didn't reproduce locally, so CI is the real check for that part.