Conversation
[RFC 7643](https://datatracker.ietf.org/doc/html/rfc7643) Introduce the security-scim-core module with Java models for SCIM User, Group, enterprise User extensions, and discovery resources. Add Micronaut Serialization and Jakarta Validation support, including schema URI handling and custom extensions. Cover every serializable model with introspection, validation, and RFC-derived JSON deserialization tests. Document installation, resource models, schema extensions, discovery resources, and the boundary between RFC 7643 models and RFC 7644 protocol operations. Every class is currently annotated with @experimental.
Member
Author
|
@graemerocher there is an open source Java library for SCIM which we could use instead. However, it is coupled to Jackson Databind |
|
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Copilot reviewed 65 out of 65 changed files in this pull request and generated 7 comments.
| } | ||
| micronautBuild { | ||
| binaryCompatibility.enabledAfter("5.4.0") | ||
| testFramework = TestFramework.JUNIT6 |
| if (!validated.contains(primarySchema)) { | ||
| throw new IllegalArgumentException("schemas must contain the primary schema " + primarySchema); | ||
| } | ||
| this.schemas = new ArrayList<>(validated); |
Comment on lines
+107
to
+112
| public void addSchema(String schema) { | ||
| String validated = requireAbsoluteUri(schema); | ||
| if (!schemas.contains(validated)) { | ||
| schemas.add(validated); | ||
| } | ||
| } |
Comment on lines
+121
to
+127
| public boolean removeSchema(String schema) { | ||
| if (primarySchema.equals(schema)) { | ||
| return false; | ||
| } | ||
| extensions.remove(schema); | ||
| return schemas.remove(schema); | ||
| } |
| @Nullable | ||
| @JsonIgnore | ||
| public Object getExtension(String schema) { | ||
| return extensions.get(schema); |
| @@ -0,0 +1,82 @@ | |||
| package io.micronaut.security.scim.core; | |||
| */ | ||
| protected ScimResource(String primarySchema) { | ||
| this.primarySchema = requireAbsoluteUri(primarySchema); | ||
| this.schemas = new ArrayList<>(List.of(primarySchema)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 7643
Introduce the security-scim-core module with Java models for SCIM User, Group, enterprise User extensions, and discovery resources.
Add Micronaut Serialization and Jakarta Validation support, including schema URI handling and custom extensions. Cover every serializable model with introspection, validation, and RFC-derived JSON deserialization tests.
Document installation, resource models, schema extensions, discovery resources, and the boundary between RFC 7643 models and RFC 7644 protocol operations.
Every class is currently annotated with @experimental.