Skip to content

don’t exclude JsonViewTest - #826

Draft
sdelamo wants to merge 1 commit into
4.12.xfrom
unignore-json-view-test
Draft

don’t exclude JsonViewTest#826
sdelamo wants to merge 1 commit into
4.12.xfrom
unignore-json-view-test

Conversation

@sdelamo

@sdelamo sdelamo commented Nov 7, 2024

Copy link
Copy Markdown
Member

JsonViewsTest::testJsonViewFlux fails:

Expected received body of '[{"id":1,"name":"Joe","password":"secret"}]' to doesnt_contain 'password'
Expected :true
Actual   :false
<Click to see difference>

org.opentest4j.AssertionFailedError: Expected received body of '[{"id":1,"name":"Joe","password":"secret"}]' to doesnt_contain 'password' ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:42)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:191)
	at io.micronaut.http.tck.BodyAssertion.evaluate(BodyAssertion.java:84)
	at io.micronaut.http.tck.AssertionUtils.assertBody(AssertionUtils.java:128)
	at io.micronaut.http.tck.AssertionUtils.assertDoesNotThrow(AssertionUtils.java:120)
	at io.micronaut.http.server.tck.tests.jsonview.JsonViewsTest.lambda$assertPath$0(JsonViewsTest.java:75)
	at io.micronaut.http.tck.TestScenario.run(TestScenario.java:118)
	at io.micronaut.http.tck.TestScenario$Builder.run(TestScenario.java:201)
	at io.micronaut.http.tck.TestScenario.asserts(TestScenario.java:67)
	at io.micronaut.http.server.tck.tests.jsonview.JsonViewsTest.assertPath(JsonViewsTest.java:72)
	at io.micronaut.http.server.tck.tests.jsonview.JsonViewsTest.testJsonViewFlux(JsonViewsTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

@yawkat

the flux test fails because it still hits this code which doesnt use the messagebodywriter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants