Skip to content

Improve E2E test Stability #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025
Merged

Conversation

aholstrup1
Copy link
Collaborator

@aholstrup1 aholstrup1 commented Jun 19, 2025

❔What, Why & How

  • Refresh E2E access token more aggressively
  • Update how app signing is validated

@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 13:59
@aholstrup1 aholstrup1 requested a review from a team as a code owner June 19, 2025 13:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refresh the E2E access token more aggressively by reducing the wait time before refreshing from 30 minutes down to 10 minutes.

  • Lower the threshold for skipping a token refresh from 30 → 10 minutes
  • Adjust the early-return logic in the RefreshToken function
Comments suppressed due to low confidence (2)

e2eTests/e2eTestHelper.psm1:70

  • The comment still refers to a 30-minute threshold but the code now uses 10 minutes. Please update the comment to reflect the new interval or make it dynamic.
        # Check if the last token refresh was more than 30 minutes ago

e2eTests/e2eTestHelper.psm1:71

  • Add or update unit/e2e tests to cover the new 10-minute refresh logic and ensure the early-return behavior works as expected.
        if ((-not $force) -and ($script:lastTokenRefresh -ne 0) -and (([DateTime]::Now - $script:lastTokenRefresh).TotalMinutes -lt 10)) {

@aholstrup1 aholstrup1 enabled auto-merge (squash) June 19, 2025 14:02
mazhelez
mazhelez previously approved these changes Jun 19, 2025
@aholstrup1 aholstrup1 changed the title Refresh E2E access token more aggressively Improve E2E test Stability Jun 20, 2025
@aholstrup1 aholstrup1 merged commit ab2f531 into main Jun 20, 2025
5 checks passed
@aholstrup1 aholstrup1 deleted the aholstrup1/refreshtokenmoreoften branch June 23, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants