-
Notifications
You must be signed in to change notification settings - Fork 151
Update each app.json once when running Increment Version Number #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that when incrementing version numbers with a relative value (e.g. "+0.1"), each app.json is only updated once per run.
- Added an
updatedAppFolders
reference parameter to track and skip already-updated app folders - Updated the main Action script to pass and accumulate
updatedAppFolders
- Expanded PowerShell tests to verify that duplicate updates do not occur
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
Tests/IncrementVersionNumber.Action.Test.ps1 | New E2E/unit tests for Set-VersionInAppManifests to assert single update |
RELEASENOTES.md | Added a note for Issue 1774 |
Actions/IncrementVersionNumber/IncrementVersionNumber.psm1 | Introduced [ref] $updatedAppFolders to avoid duplicate JSON updates |
Actions/IncrementVersionNumber/IncrementVersionNumber.ps1 | Passed the updatedAppFolders accumulator through the versioning calls |
Comments suppressed due to low confidence (1)
Actions/IncrementVersionNumber/IncrementVersionNumber.psm1:192
- [nitpick] Align this
.Parameter updatedAppFolders
entry with the other.Parameter
lines in the comment block for consistent formatting.
.Parameter updatedAppFolders
❔What, Why & How
Fix Increment Version Number to only change the versions in app.json-s only once. The issue manifests when "+0.1" is used as a parameter to increment the version number.
Related to issue: #1774
✅ Checklist