Add .pre-commit-config.yml file with pre-commit hooks #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been requested for review for almost 2 months now - can someone look at this already? If there's something missing or you need more information, please let me know. |
|
Hey @cegekaJG First of all, thank you for taking the time to contribute to the AL-Go repository. The PR looks okay. However, there's a certain process when using 3rd party frameworks for Microsoft projects, so the ball is on us to figure it out. We'll keep you posted. |
mazhelez
approved these changes
Jun 21, 2024
aholstrup1
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Looks good to me 👍 I've opened up a follow up PR to fix the findings by the pre-commit hooks #1112
freddydk
added a commit
that referenced
this pull request
Jun 24, 2024
…1112) This PR should go in after #955 This PR: * Fixes all the issues found by the pre-commit hooks (by running `pre-commit run --all-files`) * Adds a check on future AL-Go PRs to ensure the pre-commit hooks have been run. --------- Co-authored-by: Freddy Kristiansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
.pre-commit-config.yamlfile to the repository, which includes pre-commit hooks for code formatting and quality checks.The hooks can be installed locally using this guide to check for and rectify any violations before committing files, but using pre-commit.ci, it's also possible to register this repository to be automatically corrected and updated by a bot. This way, any pull requests for this project will either always adhere to guidelines defined by the hooks, or fail a status check if they require manual adjustments.
To enable pre-commit.ci, it's important to log into the service and authorize access to this repository. Beyond that, no further action is required.
Here's a list of all the hooks added with the
.pre-commit-config.ymlfile. All of them pass after a single autofix commit.