Skip to content

[#712] Add TeamsAttachmentDownloader to Core - #776

Merged
tracyboehrer (tracyboehrer) merged 11 commits into
mainfrom
southworks/update/teams-attachment-downloader
Dec 4, 2025
Merged

[#712] Add TeamsAttachmentDownloader to Core#776
tracyboehrer (tracyboehrer) merged 11 commits into
mainfrom
southworks/update/teams-attachment-downloader

Conversation

@ceciliaavila

@ceciliaavila Cecilia Avila (ceciliaavila) commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

Fixes #712

Description

This PR moves the TeamsAttachmentDownloader class from agents-hosting-extensions-teams project to agents-hosting/app.

Detailed Changes

  • Moved the TeamsAttachmentDownloader class to agents-hosting/app.
  • The TeamsAttachmentDownloader class within the Teams extensions has been marked as obsolete. Its has been extended from the new class, and the previous implementation has been removed.
  • Improved the downloadFile function adding validations, handling errors, an making the logic closer to the one in .NET.
  • Added a channel validation in the downloadFiles function.
  • Added M365Copilot to Channels list.
  • Updated the samples/teams/teamsAttachments sample to use the new class.

Testing

The following images show the teamsAttachments sample working after the changes.
image

benbrown
Ben Brown (benbrown) reviewed Nov 17, 2025
View reviewed changes
Comment thread packages/agents-hosting/src/app/teamsAttachmentDownloader.ts Outdated
benbrown
Ben Brown (benbrown) reviewed Nov 17, 2025
View reviewed changes
Comment thread packages/agents-hosting/src/app/teamsAttachmentDownloader.ts Outdated
benbrown
Ben Brown (benbrown) requested changes Nov 17, 2025
View reviewed changes

@benbrown Ben Brown (benbrown) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

@ceciliaavila

Cecilia Avila (ceciliaavila) commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator Author

left a few comments

Hi Ben Brown (@benbrown), thanks for the feedback! I answered your comments and applied a small change.

@tracyboehrer
tracyboehrer (tracyboehrer) merged commit a57865f into main Dec 4, 2025
7 checks passed
@tracyboehrer
tracyboehrer (tracyboehrer) deleted the southworks/update/teams-attachment-downloader branch December 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbrown Ben Brown (benbrown) benbrown approved these changes
@tracyboehrer tracyboehrer (tracyboehrer) Awaiting requested review from tracyboehrer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TeamsAttachmentDownloader to Core

3 participants

@ceciliaavila @benbrown @tracyboehrer