Update CalculationBaseType.Enum.al

[AydinKelky]

Summary

Update CalculationBaseType.Enum.al to Extensible=True

Fixes #4092

Fixes AB#596253

[NKarolak]

Making an Enum extensible typically (but not always) requires adding events to handle possible custom values. Have you already checked where and how this Enum is used?

[AydinKelky]

@NKarolak The enum will be used in sales subscription line from Subscription package and after posting, subscription line and customer contract subscription line but I don't undestand your question. Why for an enum to be extensible should an event be defined?

[NKarolak]

The standard code uses this Enum somewhere, I suppose.
Unless the Enum is part of an interface, you will typically find standard code that handles specific enum values (either with if or case). In such places, you need to check whether there is an event that other (your!) apps extending the Enum can subscribe to handle your custom enum values.

[AydinKelky]

@NKarolak Thanks for the clarification. There are some parts that use this enum as a parameter(case or if). Should I create events for the parts that might be causing a problem?

[NKarolak]

Should I create events for the parts that might be causing a problem?

Yes please.

If you are too unsure, maybe somebody else (Microsoft?) could close that gap later.
@JesperSchulz, does it need to be solved already in this PR? Could you assist here?

[AydinKelky]

@NKarolak It would be great if someone from Microsoft could help me with this. Thank you for your help as well :)

[AydinKelky]

@JesperSchulz Could you please help me with this issue. It's been a long time since I created this Pull and we really need to expand this enum because for migration from Singhammer to Microsoft, many of our programming depends on this enum extension. I would really appreciate it if you help us make this issue resolved. Thank you in advance

[JesperSchulz]

@JesperSchulz Could you please help me with this issue. It's been a long time since I created this Pull and we really need to expand this enum because for migration from Singhammer to Microsoft, many of our programming depends on this enum extension. I would really appreciate it if you help us make this issue resolved. Thank you in advance

Sorry, I've been on vacation the past month, but now I'm back and I'll try to get some traction on those PRs.

[djukicmilica]

Checked - we have events for handling new enum values.

[JesperSchulz]

CI is failing. Could you try pulling from main to get your branch updated?

[AydinKelky]

@JesperSchulz I updated my Branch.

[JesperSchulz]

@JesperSchulz I updated my Branch.

Thanks 🙏 Let me try to run our pipeline once more!

[AydinKelky]

@JesperSchulz I updated my branch but I checked it again now and it says it is out-of-date. What I did was I went to AydinKelky/BCApps and updated Sync fork. Please let me know if I did the update correctly. if not, please tell me what to do

[JesperSchulz]

Let's see what happens. If build passes, we're fine!