Invalid Date Formula Ratio for Subscription Package Line prevented #4171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NKarolak
suggested changes
Jul 17, 2025
src/Apps/W1/Subscription Billing/App/Contract Renewal/Tables/PlannedSubscriptionLine.Table.al
Outdated
Show resolved
Hide resolved
...Apps/W1/Subscription Billing/Test/Service Commitments/SalesServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
...Apps/W1/Subscription Billing/Test/Service Commitments/SalesServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
...Apps/W1/Subscription Billing/Test/Service Commitments/SalesServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/Test/Service Commitments/ServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/Test/Service Commitments/ServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/Test/Service Commitments/ServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/Test/Service Commitments/ServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
src/Apps/W1/Subscription Billing/Test/Service Commitments/ServiceCommitmentTest.Codeunit.al
Outdated
Show resolved
Hide resolved
miljance
force-pushed
the
InvalidDateFormulaRatioForSubscriptionBilling
branch
from
e6dfc5d to
70ad5a8
Compare
NKarolak
suggested changes
Jul 21, 2025
src/Apps/W1/Subscription Billing/App/Contract Renewal/Tables/PlannedSubscriptionLine.Table.al
Outdated
Show resolved
Hide resolved
NKarolak
approved these changes
Jul 21, 2025
pri-kise
approved these changes
Jul 30, 2025
djukicmilica
approved these changes
Aug 5, 2025
Contributor
|
@miljance, looks like our build system i acting up. Would you mind pulling from main and I'll restart the CI process? |
…idDateFormulaRatioForSubscriptionBilling
Contributor
Author
|
I hope it should work now. @JesperSchulz |
JesperSchulz
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A check whether Billing Base Period have a valid ratio should happen during field validation and not in OnModify trigger for following tables:
Work Item(s)
Fixes #4166
Fixes AB#597484