Skip to content

Insert Retention Policy Allowed Tables when open page instead #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoranpb merged 3 commits into from
Jul 24, 2025
Merged

Insert Retention Policy Allowed Tables when open page instead #4178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d60a1a7
stop inserting retention policy from OnAfterLogin
haoranpb Jul 17, 2025
8061f66
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
haoranpb Jul 22, 2025
a48f89b
Refresh the allow tables on open pgae
haoranpb Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/System Application/App/Email/src/EmailInstaller.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace System.Email;

using System.DataAdministration;
using System.Upgrade;
using System.Environment.Configuration;
using System.Reflection;

#pragma warning disable AA0235
Expand Down Expand Up @@ -62,10 +61,4 @@ codeunit 1596 "Email Installer"
begin
AddRetentionPolicyAllowedTables(true);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"System Initialization", OnAfterLogin, '', false, false)]
local procedure AddAllowedTablesOnAfterSystemInitialization()
begin
AddRetentionPolicyAllowedTables();
end;
}
7 changes: 0 additions & 7 deletions src/System Application/App/Performance Profiler/src/PerformanceProfilerInstaller.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace System.Tooling;

using System.Environment.Configuration;
using System.DataAdministration;
using System.PerformanceProfile;
using System.Upgrade;
Expand Down Expand Up @@ -56,10 +55,4 @@ codeunit 1933 "Performance Profiler Installer"
begin
AddRetentionPolicyAllowedTables(true);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"System Initialization", OnAfterLogin, '', false, false)]
local procedure AddAllowedTablesOnAfterSystemInitialization()
begin
AddRetentionPolicyAllowedTables(false);
end;
}
7 changes: 0 additions & 7 deletions src/System Application/App/Retention Policy/src/Install/RetentionPolicyInstaller.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace System.DataAdministration;

using System.Environment.Configuration;
using System.Upgrade;
using System.Environment;

Expand Down Expand Up @@ -108,10 +107,4 @@ codeunit 3907 "Retention Policy Installer"
begin
AddAllowedTables(true);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"System Initialization", OnAfterLogin, '', false, false)]
local procedure AddAllowedTablesOnAfterLogin()
begin
AddAllowedTables();
end;
}
2 changes: 2 additions & 0 deletions ...lication/App/Retention Policy/src/Retention Policy Setup/RetentionPolicySetupList.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ page 3903 "Retention Policy Setup List"
trigger OnOpenPage()
var
FeatureTelemetry: Codeunit "Feature Telemetry";
RetenPolAllowedTables: Codeunit "Reten. Pol. Allowed Tables";
begin
FeatureTelemetry.LogUptake('0000FW0', 'Retention policies', Enum::"Feature Uptake Status"::Discovered);
RetenPolAllowedTables.OnRefreshAllowedTables();
end;
}
Loading