Skip to content

[26.3] Insert Retention Policy Allowed Tables when open page instead #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoranpb merged 2 commits into from
Jul 31, 2025
Merged

[26.3] Insert Retention Policy Allowed Tables when open page instead #4282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e063bd
Insert Retention Policy Allowed Tables when open page instead (#4178)
haoranpb Jul 24, 2025
31108ca
Set upgrade tags for new companies (#4236)
haoranpb Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions src/System Application/App/Email/src/EmailInstaller.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace System.Email;

using System.DataAdministration;
using System.Upgrade;
using System.Environment.Configuration;
using System.Reflection;

#pragma warning disable AA0235
Expand Down Expand Up @@ -38,9 +37,10 @@ codeunit 1596 "Email Installer"
Field: Record Field;
RetenPolAllowedTables: Codeunit "Reten. Pol. Allowed Tables";
UpgradeTag: Codeunit "Upgrade Tag";
EmailUpgrade: Codeunit "Email Upgrade";
IsInitialSetup: Boolean;
begin
IsInitialSetup := not UpgradeTag.HasUpgradeTag(GetEmailTablesAddedToAllowedListUpgradeTag());
IsInitialSetup := not UpgradeTag.HasUpgradeTag(EmailUpgrade.GetEmailTablesAddedToAllowedListUpgradeTag());
if not (IsInitialSetup or ForceUpdate) then
exit;

Expand All @@ -49,23 +49,12 @@ codeunit 1596 "Email Installer"
RetenPolAllowedTables.AddAllowedTable(Database::"Email Inbox", Field.FieldNo(SystemCreatedAt), 2);

if IsInitialSetup then
UpgradeTag.SetUpgradeTag(GetEmailTablesAddedToAllowedListUpgradeTag());
end;

local procedure GetEmailTablesAddedToAllowedListUpgradeTag(): Code[250]
begin
exit('MS-373161-EmailLogEntryAdded-20201005');
UpgradeTag.SetUpgradeTag(EmailUpgrade.GetEmailTablesAddedToAllowedListUpgradeTag());
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Reten. Pol. Allowed Tables", OnRefreshAllowedTables, '', false, false)]
local procedure AddAllowedTablesOnRefreshAllowedTables()
begin
AddRetentionPolicyAllowedTables(true);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"System Initialization", OnAfterLogin, '', false, false)]
local procedure AddAllowedTablesOnAfterSystemInitialization()
begin
AddRetentionPolicyAllowedTables();
end;
}
7 changes: 7 additions & 0 deletions src/System Application/App/Email/src/EmailUpgrade.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ codeunit 1597 "Email Upgrade"
exit('MS-592720-DefaultEmailMaxConcurrencyLimitChanged-20250723');
end;

procedure GetEmailTablesAddedToAllowedListUpgradeTag(): Code[250]
begin
exit('MS-373161-EmailLogEntryAdded-20201005');
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Upgrade Tag", OnGetPerCompanyUpgradeTags, '', false, false)]
local procedure RegisterPerCompanyTags(var PerCompanyUpgradeTags: List of [Code[250]])
var
Expand All @@ -75,5 +80,7 @@ codeunit 1597 "Email Upgrade"
PerCompanyUpgradeTags.Add(GetDefaultEmailViewPolicyUpgradeTag());
if not UpgradeTag.HasUpgradeTag(GetDefaultEmailMaxConcurrencyLimitUpgradeTag()) then
PerCompanyUpgradeTags.Add(GetDefaultEmailMaxConcurrencyLimitUpgradeTag());
if not UpgradeTag.HasUpgradeTag(GetEmailTablesAddedToAllowedListUpgradeTag()) then
PerCompanyUpgradeTags.Add(GetEmailTablesAddedToAllowedListUpgradeTag());
end;
}
10 changes: 6 additions & 4 deletions src/System Application/App/Performance Profiler/src/PerformanceProfilerInstaller.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace System.Tooling;

using System.Environment.Configuration;
using System.DataAdministration;
using System.PerformanceProfile;
using System.Upgrade;
Expand Down Expand Up @@ -57,9 +56,12 @@ codeunit 1933 "Performance Profiler Installer"
AddRetentionPolicyAllowedTables(true);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"System Initialization", OnAfterLogin, '', false, false)]
local procedure AddAllowedTablesOnAfterSystemInitialization()
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Upgrade Tag", OnGetPerCompanyUpgradeTags, '', false, false)]
local procedure RegisterPerCompanyTags(var PerCompanyUpgradeTags: List of [Code[250]])
var
UpgradeTag: Codeunit "Upgrade Tag";
begin
AddRetentionPolicyAllowedTables(false);
if not UpgradeTag.HasUpgradeTag(GetPerformanceProfileAddedToAllowedListUpgradeTag()) then
PerCompanyUpgradeTags.Add(GetPerformanceProfileAddedToAllowedListUpgradeTag());
end;
}
10 changes: 6 additions & 4 deletions src/System Application/App/Retention Policy/src/Install/RetentionPolicyInstaller.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace System.DataAdministration;

using System.Environment.Configuration;
using System.Upgrade;
using System.Environment;

Expand Down Expand Up @@ -109,9 +108,12 @@ codeunit 3907 "Retention Policy Installer"
AddAllowedTables(true);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"System Initialization", OnAfterLogin, '', false, false)]
local procedure AddAllowedTablesOnAfterLogin()
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Upgrade Tag", OnGetPerCompanyUpgradeTags, '', false, false)]
local procedure RegisterPerCompanyTags(var PerCompanyUpgradeTags: List of [Code[250]])
var
UpgradeTag: Codeunit "Upgrade Tag";
begin
AddAllowedTables();
if not UpgradeTag.HasUpgradeTag(GetRetenPolLogEntryAddedUpgradeTag()) then
PerCompanyUpgradeTags.Add(GetRetenPolLogEntryAddedUpgradeTag());
end;
}
2 changes: 2 additions & 0 deletions ...lication/App/Retention Policy/src/Retention Policy Setup/RetentionPolicySetupList.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ page 3903 "Retention Policy Setup List"
trigger OnOpenPage()
var
FeatureTelemetry: Codeunit "Feature Telemetry";
RetenPolAllowedTables: Codeunit "Reten. Pol. Allowed Tables";
begin
FeatureTelemetry.LogUptake('0000FW0', 'Retention policies', Enum::"Feature Uptake Status"::Discovered);
RetenPolAllowedTables.OnRefreshAllowedTables();
end;
}
Loading