Skip to content

Conversation

AndreiPanko
Copy link
Contributor

@AndreiPanko AndreiPanko commented Oct 15, 2025

Summary

  • include Shopify channelLiable flag in all order and shipment GraphQL queries
  • persist channel liable taxes on orders to import and headers with UI exposure
  • add comprehensive tests for channelLiable scenarios across staging and import flows

Testing

  • Not run (requires Business Central test suite)

Fixes: AB#608939

@AndreiPanko AndreiPanko requested a review from a team as a code owner October 15, 2025 13:01
@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Oct 15, 2025
@github-actions github-actions bot added this to the Version 28.0 milestone Oct 15, 2025
@AndreiPanko AndreiPanko requested a review from Copilot October 15, 2025 13:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for tracking Shopify's channel liable tax flag throughout the order handling process. Channel liable taxes indicate when a sales channel (rather than the merchant) is responsible for collecting and remitting taxes.

Key changes:

  • Added Channel Liable field to order tax lines and Channel Liable Taxes calculated field to order headers
  • Updated all GraphQL queries to retrieve the channelLiable field from Shopify
  • Added comprehensive test coverage for all channelLiable scenarios (missing, true, false, null)

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
ShpfyOrdersAPITest.Codeunit.al Added 8 test procedures covering channelLiable flag handling in staging and import flows
ShpfyOrdersToImport.Table.al Added Channel Liable Taxes boolean field to staging table
ShpfyOrderTaxLine.Table.al Added Channel Liable boolean field to tax line table
ShpfyOrderHeader.Table.al Added Channel Liable Taxes FlowField calculated from tax lines
ShpfySyncOrdersfromShopify.Report.al Added Channel Liable Taxes to request filter fields
ShpfyOrdersToImport.Page.al Added Channel Liable Taxes field to staging page UI
ShpfyOrders.Page.al Added Channel Liable Taxes field to orders list page
ShpfyOrderTaxLines.Page.al Added Channel Liable field to tax lines page
ShpfyOrder.Page.al Added Channel Liable Taxes field to order detail page
ShpfyOrdersAPI.Codeunit.al Added ContainsChannelLiableTax function to check first tax line
ShpfyImportOrder.Codeunit.al Added channelLiable field extraction during tax line import
ShpfyGQL*.Codeunit.al (6 files) Updated GraphQL queries to include channelLiable and adjusted expected costs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AndreiPanko AndreiPanko requested a review from onbuyuka October 17, 2025 07:35
@AndreiPanko AndreiPanko self-assigned this Oct 17, 2025
@AndreiPanko AndreiPanko added the Approved The issue is approved label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Approved The issue is approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant