-
Notifications
You must be signed in to change notification settings - Fork 259
Add channel liable tax tracking for Shopify orders #5200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for tracking Shopify's channel liable tax flag throughout the order handling process. Channel liable taxes indicate when a sales channel (rather than the merchant) is responsible for collecting and remitting taxes.
Key changes:
- Added
Channel Liable
field to order tax lines andChannel Liable Taxes
calculated field to order headers - Updated all GraphQL queries to retrieve the
channelLiable
field from Shopify - Added comprehensive test coverage for all channelLiable scenarios (missing, true, false, null)
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
ShpfyOrdersAPITest.Codeunit.al | Added 8 test procedures covering channelLiable flag handling in staging and import flows |
ShpfyOrdersToImport.Table.al | Added Channel Liable Taxes boolean field to staging table |
ShpfyOrderTaxLine.Table.al | Added Channel Liable boolean field to tax line table |
ShpfyOrderHeader.Table.al | Added Channel Liable Taxes FlowField calculated from tax lines |
ShpfySyncOrdersfromShopify.Report.al | Added Channel Liable Taxes to request filter fields |
ShpfyOrdersToImport.Page.al | Added Channel Liable Taxes field to staging page UI |
ShpfyOrders.Page.al | Added Channel Liable Taxes field to orders list page |
ShpfyOrderTaxLines.Page.al | Added Channel Liable field to tax lines page |
ShpfyOrder.Page.al | Added Channel Liable Taxes field to order detail page |
ShpfyOrdersAPI.Codeunit.al | Added ContainsChannelLiableTax function to check first tax line |
ShpfyImportOrder.Codeunit.al | Added channelLiable field extraction during tax line import |
ShpfyGQL*.Codeunit.al (6 files) | Updated GraphQL queries to include channelLiable and adjusted expected costs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
Testing
Fixes: AB#608939