Invoice Details for "Unit Cost Surcharge" #5280
Open
+331
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AL: Apps (W1)
pri-kise
reviewed
Oct 23, 2025
...s/W1/Subscription Billing/Demo Data/Demo Data/2.Master Data/CreateSubBillGenSett.Codeunit.al
Outdated
Show resolved
Hide resolved
samra-singhammer
suggested changes
Oct 23, 2025
src/Apps/W1/Subscription Billing/App/Billing/Codeunits/SubContractBillingPrintout.Codeunit.al
Outdated
Show resolved
Hide resolved
|
|
||
| internal procedure CreateUsageDataBillingFromTempServiceCommitments(var TempServiceCommitment: Record "Subscription Line"; SupplierNo: Code[20]; UsageDataImportEntryNo: Integer; ServiceObjectNo: Code[20]; BillingPeriodStartDate: Date; | ||
| BillingPeriodEndDate: Date; UnitCost: Decimal; NewQuantity: Decimal; CostAmount: Decimal; UnitPrice: Decimal; NewAmount: Decimal; CurrencyCode: Code[10]) | ||
| internal procedure CreateUsageDataBillingFromTempServiceCommitments( |
There was a problem hiding this comment.
Is it safe to extend the internal procedure with parameters?
There was a problem hiding this comment.
Generally good question but in this instance this function is not referenced in any of the xxx Microsoft Apps. In this instance I would change the parameters before the new Connector other than Generic one is introduced.
| CreateUsageDataBilling.CreateUsageDataBillingFromTempServiceCommitments(TempServiceCommitment, UsageDataImport."Supplier No.", UsageDataGenericImportGlobal."Usage Data Import Entry No.", UsageDataGenericImportGlobal."Subscription Header No.", UsageDataGenericImportGlobal."Billing Period Start Date", | ||
| UsageDataGenericImportGlobal."Billing Period End Date", UsageDataGenericImportGlobal.Cost, UsageDataGenericImportGlobal.Quantity, | ||
| UsageDataGenericImportGlobal."Cost Amount", UsageDataGenericImportGlobal.Price, UsageDataGenericImportGlobal.Amount, UsageDataGenericImportGlobal.GetCurrencyCode()); | ||
| CreateUsageDataBilling.CreateUsageDataBillingFromTempServiceCommitments( |
There was a problem hiding this comment.
Would you agree that UsageDataGenericImportGlobal can be sent as a parameter instead of passing 10 of it's fields?
There was a problem hiding this comment.
Good observation. Would be nice, however this function should also be used by other connectors later on which might and will have different field names.
...W1/Subscription Billing/App/Usage Based Billing/Codeunits/CreateUsageDataBilling.Codeunit.al
Outdated
Show resolved
Hide resolved
pri-kise
reviewed
Oct 23, 2025
...s/W1/Subscription Billing/Demo Data/Demo Data/2.Master Data/CreateSubBillGenSett.Codeunit.al
Outdated
Show resolved
Hide resolved
pri-kise
approved these changes
Oct 23, 2025
samra-singhammer
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work Item(s)
Fixes #4485