-
Notifications
You must be signed in to change notification settings - Fork 261
Fix uv_loop_close sequence to wait for in-flight synchronous calls that hold uv resources #7070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Amaury Chamayou (achamayou)
merged 8 commits into
microsoft:main
from
cjen1-msft:fix-fsync-race
Aug 14, 2025
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e5b6ac
MUST REVERT: add delayed thread
cjen1-msft 0c1122c
Wait 10s for completion of uv_loop
cjen1-msft 79d8daa
Revert "MUST REVERT: add delayed thread"
cjen1-msft aa9ee41
tidy loop iterator
cjen1-msft 4e5f341
Merge branch 'main' into fix-fsync-race
cjen1-msft 17d10be
Update src/host/run.cpp
cjen1-msft ea2001c
Update src/host/run.cpp
cjen1-msft 043761d
Merge branch 'main' into fix-fsync-race
achamayou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.