Skip to content

[ExecutionTests] Fix shader source to prevent OOB access for ExecutionTests::AtomicsShared64Test #7641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

[ExecutionTests] Fix shader source to prevent OOB access for ExecutionTests::AtomicsShared64Test #7641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be5010
Fix shader source for int64 atomics test
alsepkow Jul 12, 2025
9f46225
Fix similar issue in AtmoicsHeap as well
alsepkow Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tools/clang/unittests/HLSLExec/ShaderOpArith.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,7 +1976,7 @@
RWStructuredBuffer<uint64_t> g_shareXchg64Buf : register(u5);

groupshared uint64_t g_uint64Share[6];
groupshared int64_t g_sint64Share[3];
groupshared int64_t g_sint64Share[4];
groupshared uint64_t g_xchg64Share[64];

#define VEC_CALL(op, uav, ix, val) op(uav[ix*stride], val);
Expand Down Expand Up @@ -2046,7 +2046,7 @@
// Zero-init shared memory, with special cases
if (ix < 6)
g_uint64Share[ix] = ix == 1 ? 99999999ULL | (99999999ULL << 32) : ix == 3 ? ~0ULL : 0;
if (ix < 3)
if (ix < 4)
g_sint64Share[ix] = ix == 1 ? 99999999ULL | (99999999ULL << 32) : 0;
if (ix < 64)
g_xchg64Share[ix] = 0;
Expand Down Expand Up @@ -2552,11 +2552,11 @@

void InitSharedMem(uint ix) {
// Zero-init shared memory, with special cases
if (ix < 6)
if (ix < 7)
g_uintShare[ix] = ix == 1 ? 99999999 : ix == 3 ? -1 : 0;
if (ix < 3)
if (ix < 4)
g_sintShare[ix] = ix == 1 ? 99999999 : 0;
if (ix < 64)
if (ix < 65)
g_xchgShare[ix] = 0;

GroupMemoryBarrierWithGroupSync();
Expand Down