[SPIRV] Fix DebugSource for files which are not found #7662
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
approved these changes
Jul 24, 2025
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4218 and #4362 identified and partially fixed problems with DebugSource generation. #6085 recognized that exe and API users were having different outputs in DebugSource, and attempted to fix that. However, as the conversation in #7569 shows, the solution was not entirely correct. This PR causes dxc to connect the input source string, whether by exe or API, to one and only one DebugSource, like other compilers. Files which are not found produce a DebugSource without the second operand.
This PR fixes #7569