-
Notifications
You must be signed in to change notification settings - Fork 803
Adding IsFinite, IsInf and IsNan long vector tests #7836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f54718e
adding test?
joaosaffran b8585b8
remove input set
joaosaffran 0495fd5
adding test
joaosaffran 271cb0a
fix
joaosaffran 20eaa93
Merge branch 'main' into test/isfinite
joaosaffran 27f4e31
adding other numeric types test
joaosaffran 5d66ed8
clean up
joaosaffran 068f4fc
reduce tests to only float point types
joaosaffran c51afa9
format
joaosaffran dbbc868
add weird values
joaosaffran-zz eab4ea4
remove double
joaosaffran a4de02c
adding other tests
joaosaffran 57a6be9
rename input set
joaosaffran 76ca7ce
using OP_DEFAULT
joaosaffran 3bd8288
addressing comments
joaosaffran 500ba14
format
joaosaffran 56930db
format
joaosaffran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1140,6 +1140,20 @@ STRICT_OP_1(OpType::LoadAndStore_DT_SB_SRV, (A)); | |||||||||||||||||
| STRICT_OP_1(OpType::LoadAndStore_RD_SB_UAV, (A)); | ||||||||||||||||||
| STRICT_OP_1(OpType::LoadAndStore_RD_SB_SRV, (A)); | ||||||||||||||||||
|
|
||||||||||||||||||
| // | ||||||||||||||||||
| // Float Ops | ||||||||||||||||||
| // | ||||||||||||||||||
|
|
||||||||||||||||||
| #define FLOAT_SPECIAL_OP(OP, IMPL) \ | ||||||||||||||||||
| template <typename T> struct Op<OP, T, 1> : StrictValidation { \ | ||||||||||||||||||
| HLSLBool_t operator()(T A) { return IMPL; } \ | ||||||||||||||||||
| }; | ||||||||||||||||||
|
|
||||||||||||||||||
| FLOAT_SPECIAL_OP(OpType::IsFinite, (std::isfinite(A))); | ||||||||||||||||||
| FLOAT_SPECIAL_OP(OpType::IsInf, (std::isinf(A))); | ||||||||||||||||||
| FLOAT_SPECIAL_OP(OpType::IsNan, (std::isnan(A))); | ||||||||||||||||||
| #undef FLOAT_SPECIAL_OP | ||||||||||||||||||
|
|
||||||||||||||||||
| // | ||||||||||||||||||
| // dispatchTest | ||||||||||||||||||
| // | ||||||||||||||||||
|
|
@@ -1671,6 +1685,16 @@ class DxilConf_SM69_Vectorized { | |||||||||||||||||
| HLK_TEST(Abs, double); | ||||||||||||||||||
| HLK_TEST(Sign, double); | ||||||||||||||||||
|
|
||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
| // Float Special | ||||||||||||||||||
|
|
||||||||||||||||||
| HLK_TEST(IsFinite, HLSLHalf_t); | ||||||||||||||||||
| HLK_TEST(IsInf, HLSLHalf_t); | ||||||||||||||||||
| HLK_TEST(IsNan, HLSLHalf_t); | ||||||||||||||||||
|
|
||||||||||||||||||
| HLK_TEST(IsFinite, float); | ||||||||||||||||||
| HLK_TEST(IsInf, float); | ||||||||||||||||||
| HLK_TEST(IsNan, float); | ||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: The other test cases are organized in groups by input type
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| // Binary Comparison | ||||||||||||||||||
|
|
||||||||||||||||||
| HLK_TEST(LessThan, int16_t); | ||||||||||||||||||
|
|
||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.