Add proto services for python clients to use #170
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Julien Maffre <[email protected]>
added 16 commits
November 10, 2022 13:50
* Simplify notice_check script * Add license header to k6.js * Update git ls-files for notice checks * Format * Fixup licenses * Redo notice check * Remove extra import * Fixup notice check * Move notice check to after python deps are installed
added 11 commits
November 10, 2022 14:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the service definitions to the
*.protofiles so that when generating code we can also generate clients (python in this case).With these generated files we could make a nice python client library for the gRPC endpoints (and provide similar functionality for the json endpoints).
This also generates an
openapi.yamlfile when building.