-
-
Notifications
You must be signed in to change notification settings - Fork 675
feat: add evolving history and status to runner #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rui/add_runner_history
…oder and feedback in runner
rdagent/core/evolving_agent.py
Outdated
@@ -79,10 +79,17 @@ def multistep_evolve( | |||
# TODO: Putting the evolving trace in here doesn't actually work | |||
queried_knowledge = self.rag.query(evo, self.evolving_trace) | |||
|
|||
# 2.5 Brief evolving history | |||
evolving_history = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we defer therender it to last step
rdagent/core/evolving_agent.py
Outdated
@@ -92,7 +99,7 @@ def multistep_evolve( | |||
# 5. Evaluation | |||
if self.with_feedback: | |||
es.feedback = ( | |||
eva if isinstance(eva, Feedback) else eva.evaluate(evo, queried_knowledge=queried_knowledge) | |||
eva if isinstance(eva, Feedback) else eva.evaluate(evo, evolving_history=evolving_history) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have to remove queried_knowledge=queried_knowledge
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not used in current runner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rdagent/core/evolving_framework.py
Outdated
@@ -51,6 +51,13 @@ class EvoStep: | |||
evolvable_subjects: EvolvableSubjects | |||
queried_knowledge: QueriedKnowledge | None = None | |||
feedback: Feedback | None = None | |||
code_change_summary: str | None = None # TODO: minrui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this place is a good place to add summary,
Let's have the discussion later.
@@ -48,6 +64,7 @@ def evaluate( | |||
implementation: FBWorkspace, | |||
gt_implementation: FBWorkspace, | |||
queried_knowledge: QueriedKnowledge = None, | |||
evolving_history: tuple = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eolving_trace
## Output Format | ||
{% if out_spec %} | ||
{{ out_spec }} | ||
{% else %} | ||
Please response the code in the following JSON format without anything else. | ||
{ | ||
"code": "The Python code as a string." | ||
"code": "The refined Python code as a string." | ||
"code_change_summary": "The structured summary to briefly summarize the changes made to the original code base in two to three sentences." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember change
…rui/add_runner_history
fd27cb7
to
1064b68
Compare
…rui/add_runner_history
…rui/add_runner_history
This pr is intended to: