Skip to content

Accept type argument to getElementById #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Accept type argument to getElementById #2145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9031d1d
Accept type argument to getElementById
Sainan Sep 9, 2025
1efc911
accept new baselines
Sainan Sep 9, 2025
ec20095
extends HTMLElement
Sainan Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10577,7 +10577,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/exitPointerLock)
*/
exitPointerLock(): void;
getElementById(elementId: string): HTMLElement | null;
getElementById<T extends HTMLElement = HTMLElement>(elementId: string): T | null;
/**
* The **`getElementsByClassName`** method of Document interface returns an array-like object of all child elements which have all of the given class name(s).
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10569,7 +10569,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/exitPointerLock)
*/
exitPointerLock(): void;
getElementById(elementId: string): HTMLElement | null;
getElementById<T extends HTMLElement = HTMLElement>(elementId: string): T | null;
/**
* The **`getElementsByClassName`** method of Document interface returns an array-like object of all child elements which have all of the given class name(s).
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10577,7 +10577,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/exitPointerLock)
*/
exitPointerLock(): void;
getElementById(elementId: string): HTMLElement | null;
getElementById<T extends HTMLElement = HTMLElement>(elementId: string): T | null;
/**
* The **`getElementsByClassName`** method of Document interface returns an array-like object of all child elements which have all of the given class name(s).
*
Expand Down
2 changes: 1 addition & 1 deletion inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@
"getElementById": {
"name": "getElementById",
"overrideSignatures": [
"getElementById(elementId: string): HTMLElement | null"
"getElementById<T extends HTMLElement = HTMLElement>(elementId: string): T | null"
]
},
"getElementsByTagNameNS": {
Expand Down