Skip to content

Fix debug assertion failure in move to file refactor for React components #62067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix debug assertion failure in move to file refactor for React components #62067

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7dd3d82
Initial plan
Copilot Jul 14, 2025
917e69c
Initial commit: Analyzing move to file refactor issue with React comp…
Copilot Jul 14, 2025
05666fc
Fix move to file refactor issue with React components
Copilot Jul 14, 2025
be81535
Final formatting and test validation
Copilot Jul 14, 2025
dbfbc0e
Revert code changes and create test case that triggers original asser…
Copilot Jul 14, 2025
ed65054
Fix debug assertion failure in move to file refactor for symbols expo…
Copilot Jul 14, 2025
6eb7cb8
Fix debug assertion failure in move to file refactor for symbols expo…
Copilot Jul 14, 2025
4072666
Apply formatting changes
Copilot Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/services/refactors/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,14 @@ export function addTargetFileImports(
}
else if (targetSymbol.parent === undefined) {
Debug.assert(declaration !== undefined, "expected module symbol to have a declaration");
importAdder.addImportForModuleSymbol(symbol, isValidTypeOnlyUseSite, declaration);
const aliasedSymbol = checker.getAliasedSymbol(symbol);
if (aliasedSymbol.flags & SymbolFlags.Module) {
importAdder.addImportForModuleSymbol(symbol, isValidTypeOnlyUseSite, declaration);
}
else {
// If the aliased symbol is not a module, fall back to verbatim import
importAdder.addVerbatimImport(Debug.checkDefined(declaration ?? findAncestor(symbol.declarations?.[0], isAnyImportOrRequireStatement)));
}
}
else {
importAdder.addImportFromExportedSymbol(targetSymbol, isValidTypeOnlyUseSite, declaration);
Expand Down