Skip to content

Retrieving Disk Paths via DiskManager #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Retrieving Disk Paths via DiskManager #440

wants to merge 18 commits into from

Conversation

ericavella
Copy link
Contributor

No description provided.

yangpanMS
yangpanMS reviewed Feb 19, 2025
View reviewed changes
yangpanMS
yangpanMS reviewed Feb 19, 2025
View reviewed changes
yangpanMS
yangpanMS requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to understand more about this. Could you use Disks.GetPreferredPath in the component that needs this? If you don't want to use foreach, you could write an extension just on the Disks.

@yangpanMS
Copy link
Contributor

Could you remind me if we still need this? Also would we change this for FIO only or we need to modify it for all IO workloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangpanMS yangpanMS yangpanMS requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericavella @yangpanMS