Add support for IntelliJ EAP 2025.3 #11391
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Toolkit for IntelliJ to support IntelliJ IDEA 2025.3 EAP. The update involves upgrading the IntelliJ Platform version from 252 (2025.2) to 253 (2025.3), along with corresponding changes to build dependencies and Java version requirements.
Key changes:
- Updated IntelliJ Platform version to 253-EAP-SNAPSHOT (2025.3) with Java 21 requirement
- Upgraded Gradle (8.8 → 8.14.1), Kotlin (2.1.0 → 2.2.20), and various plugin dependencies
- Adapted API changes including removal of deprecated
setWindowSizemethod and replacement ofnamedChildScopewithchildScope
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle-wrapper.properties | Updated Gradle wrapper to version 8.14.1 |
| libs.versions.toml | Upgraded Kotlin, changelog, intellijPlatform, and springDependencyManagement plugin versions |
| gradle.properties | Updated IntelliJ version to 253-EAP-SNAPSHOT and Java version to 21 |
| build.gradle.kts | Updated Java toolchain to version 21, removed instrumentCode configuration, and added conditional instrumentCode task |
| ResourceGroupCreationDialog.java/.form | Added GUI Designer generated code and label binding |
| ServicePlanCreationDialog.java/.form | Added GUI Designer generated code and label bindings |
| AppServiceInfoBasicPanel.java/.form | Added GUI Designer generated code |
| azure-intellij-plugin-lib/build.gradle.kts | Added jackson-dataformat-yaml dependency |
| azure-intellij-plugin-guidance/build.gradle.kts | Added jackson-dataformat-yaml dependency |
| SparkBatchJobProcessAdapter.kt | Removed deprecated setWindowSize method override |
| SparkLivySessionProcess.kt | Removed deprecated setWindowSize method override |
| AzureCloudTerminalRunner.kt | Replaced namedChildScope API with childScope |
| azure-intellij-plugin-hdinsight-lib/build.gradle.kts | Commented out intellijIdeaUltimate dependency declaration |
| azure-intellij-plugin-cosmos/build.gradle.kts | Commented out intellijIdeaUltimate dependency declaration |
| azure-intellij-plugin-appservice/build.gradle.kts | Added instrumentCode task configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| intellijPlatform = "2.3.0" | ||
| kotlin = "2.2.20" | ||
| changelog = "2.4.0" | ||
| #intellijPlatform = "2.10.1" |
There was a problem hiding this comment.
Duplicate assignment of intellijPlatform version with one commented out. Remove the commented line to eliminate redundancy.
| #intellijPlatform = "2.10.1" |
| intellijPlatform { | ||
| buildSearchableOptions = false | ||
| instrumentCode = true | ||
| // instrumentCode = true |
There was a problem hiding this comment.
Commented-out code should be removed rather than left in the codebase. If this configuration is no longer needed, delete the comment.
| // instrumentCode = true |
| projectName = "azure-toolkit-for-intellij" | ||
| buildSearchableOptions = false | ||
| instrumentCode = true | ||
|
|
There was a problem hiding this comment.
Removed configuration 'instrumentCode = true' appears to be intentional based on the new conditional task configuration added earlier. However, this creates inconsistency as the same setting is removed here but conditionally enabled in the tasks block. Consider documenting why this global setting was removed.
| // Note: The global 'instrumentCode = true' configuration was intentionally removed. | |
| // Instead, 'instrumentCode' is now conditionally enabled in the tasks block above. | |
| // This allows for more granular control over which tasks have code instrumentation enabled, | |
| // and avoids instrumenting code globally when not needed. |
| { | ||
| // GUI initializer generated by IntelliJ IDEA GUI Designer | ||
| // >>> IMPORTANT!! <<< | ||
| // DO NOT EDIT OR ADD ANY CODE HERE! | ||
| $$$setupUI$$$(); | ||
| } |
There was a problem hiding this comment.
The instance initializer block calling $$$setupUI$$$() is auto-generated UI code. While this is standard for IntelliJ's GUI Designer, ensure that any manual UI initialization in the constructor doesn't conflict with this auto-generated code.
| import javax.swing.text.StyleContext; | ||
| import java.awt.*; | ||
| import java.util.*; | ||
| import java.util.List; |
There was a problem hiding this comment.
Redundant import of java.util.List when java.util.* is already imported on line 38. Remove this specific import.
| import java.util.List; |
1 participant
What does this implement/fix? Explain your changes.
…
Does this close any currently open issues?
Any relevant logs, screenshots, error output, etc.?
Any other comments?
…
Has this been tested?