Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,16 @@ def evaluate(expression: str, state: PipelineRunState) -> Union[str, int, float,

activity_results = {}
for activity in state.activity_results:
activity_result_dir = {
"outputs": {
"body": {
"output": activity.output,
"status": activity.status,
"error": activity.error,
}
}
output_body = {
k: v
for k, v in {
"error": activity.error,
"output": activity.output,
"status": activity.status.value if activity.status is not None else None,
}.items()
if v is not None
}
activity_results[activity.activity_name] = activity_result_dir
activity_results[activity.activity_name] = {"outputs": {"body": output_body}}

variables = {variable.name: variable.value for variable in state.variables}

Expand Down
4 changes: 2 additions & 2 deletions src/data_factory_testing_framework/state/_activity_result.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class ActivityResult:
def __init__(
self,
activity_name: str,
status: Optional[DependencyCondition] = None,
status: Optional[DependencyCondition] = DependencyCondition.SUCCEEDED,
output: Optional[Any] = None, # noqa: ANN401
error: Optional[Any] = None, # noqa: ANN401
) -> None:
Expand All @@ -20,7 +20,7 @@ def __init__(
error: Error of the activity. (e.g. { "code": "ErrorCode", "message": "ErrorMessage" } for activity('activityName').Error)
"""
self.activity_name = activity_name
self.status = status if status is not None else DependencyCondition.SUCCEEDED
self.status = status
self.output = output
self.error = error

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,41 @@ def test_evaluate_function_names_are_case_insensitive() -> None:
# Assert
assert evaluated_value == "ab"

@pytest.mark.parametrize(
["expression", "property_name"],
[
p("@contains(createArray(activity('Fail').status,activity('Notebook').status),'Failed')", "status", id="status"),
p("@contains(createArray(activity('Fail').status,activity('Notebook').error),'Succeeded')", "error", id="error"),
p("@contains(createArray(activity('Fail').status,activity('Notebook').output),'Succeeded')", "output", id="output"),
],
)
def test_evaluate_expression_with_none_activity_result_raises_exception(
expression: str, property_name: str,
) -> None:
# Arrange
expression_runtime = ExpressionRuntime()
state = PipelineRunState(
activity_results=[
ActivityResult(
activity_name="Fail",
status=DependencyCondition.FAILED,
output={},
),
ActivityResult(
activity_name="Notebook",
status=None,
output=None,
error=None,
),
]
)

# Act & Assert
with pytest.raises(ParameterNotFoundError) as exinfo:
expression_runtime.evaluate(expression, state)

assert str(exinfo.value) == f"Parameter: '{property_name}' of type 'RunParameterType.System' not found"


def test_evaluate_function_with_null_conditional_operator() -> None:
# Arrange
Expand Down
Loading