fix(fast-html): enhance boolean resolution in resolveExpression function #7222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radium-v
changed the title
janechu
requested changes
Nov 24, 2025
Collaborator
janechu
left a comment
janechu
left a comment
There was a problem hiding this comment.
Can you add some tests?
mohamedmansour
approved these changes
Nov 24, 2025
janechu
approved these changes
Nov 25, 2025
chrisdholt
approved these changes
Nov 25, 2025
radium-v
force-pushed
the
users/radium-v/lefthand-evaluation
branch
from
7ae1cff to
513664b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR ensures that lefthand-only expressions in
<f-when>conditions are evaluated based on their type.📑 Test Plan
All tests should pass.
✅ Checklist
General
$ npm run change