Repository navigation
fix(react-toast): report status for imperative dismissal - #36865
Open
Minwook Shin (minwookshin) wants to merge 1 commit into
Open
Minwook Shin (minwookshin) wants to merge 1 commit into
Minwook Shin (minwookshin) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
dismissToastanddismissAllToastshide visible toasts without reporting thedismissedstatus.New Behavior
Route imperative dismissal through the existing close path and report dismissal once per visible toast. Clear the queue before dismiss-all callbacks and preserve any new toast dispatched by a callback. Queued-toast behavior and React Strict Mode effect replay are unchanged.
Validated with 219 toast tests (16 suites), library/spec/Cypress type checks, package build, lint, and formatting. Added regressions fail before the fix.
Related Issue(s)
Fixes #36862