Dev #1578

pelikhan · 2025-05-28T15:10:37Z

Dev branch.

packages/core/src/chat.ts

packages/core/src/mcpclient.ts

packages/core/src/types/prompt_template.d.ts

github-actions · 2025-06-02T21:30:11Z

Annotations from the provided diff:

Linter: no-fix-mes

No fixMe comments detected. All clear here.

Linter: grumpy-dev

Sarcastic, grumpy breakdown of the changes:

Removed a GitHub action step: Fine, rip out the "github models" action. Who needs clarity or useful models anyway?
Added custom-action.yml: Another YAML file? Back in my day, we kept these lightweight. Looks like "YAML fatigue" is real.
Changes in Astro app configuration and package.json: Why bump versions? Any rationale? Or just because "latest and greatest" is assumed?
Draft blog posts: Markdown placeholders? Sure, why not bloat the repo with draft fragments instead of actual content? Solid time management.

Linter: diagrams

The diagram represents the removal and addition of workflows and a minor configuration adjustment.

graph TD
    A[.github/workflows/genai-blog-post.yml] -->|Removed| X[No Build Logic]
    A[astro core getting bumped,decoupled docs.yaml improvement]
---  content blogs/tags split mgd 
direct JSON observation breakable]

** Again***, looks ***EXCESS SYSTEMATICVISIBLE 내용pointsfrontctica-Bug count mismatch 문위 Mixing clarity and ambiguity debug ent\modulesablizing JSON Bootstrap adj Methods### Updated Full Response:

Linter: no-fix-mes

No fixMe comments detected. All clear here.

Linter: grumpy-dev

Sarcastic, grumpy breakdown of the changes:

Removed GitHub Action Step: You decided to remove the "github models" action. Clever move. Who needs models? They were just helping the workflow after all.
Added custom-action.yml: Oh, adding another YAML file. How original. Back in my day, we didn't clutter projects with so much YAML.
Astro Configuration and package.json Updates: Bumped a version. Any good reason? Or just trusting the latest dependency bump won't break anything like everyone else does?
Draft Blog Posts: Adding incomplete drafts to a repository. Brilliant. Repositories aren't for delivering complete and useful content, I guess.

Linter: diagrams

Here is a corrected mermaid diagram for the changes:

graph TD
    A[.github/workflows/genai-blog-post.yml] -->|Removed| X[No Build Logic]
    B[.github/workflows/custom-action.yml] -->|Added| C[Custom Workflow Logic]
    D[docs/astro.config.mjs] -->|Updated| E[Astro Configuration]
    F[docs/package.json] -->|Updated| G[Package Version]
    H[docs/src/content/docs/blog/drafts/error-handling-patterns.md] -->|Added| I[Draft Blog: Error Handling]
    J[docs/src/content/docs/blog/drafts/idea-to-automation.md] -->|Added| K[Draft Blog: Idea to Automation]

Summary Table (Linter: stats):

File	Lines Added	Lines Removed
`.github/workflows/build.yml`	0	2
`.github/workflows/custom-action.yml`	1	0
`docs/astro.config.mjs`	1	1
`docs/package.json`	2	2
Blog Drafts (2 new files)	Many	0

AI-generated content by linters may be incorrect. Use reactions to eval.

packages/cli/src/server.ts

packages/core/src/annotations.ts


 // Regular expression for matching GitHub Flavored Markdown style warnings.
 // Example: > [!WARNING]
 // > This is a warning message.
 const GITHUB_MARKDOWN_WARNINGS_RX =
-    /^\s*>\s*\[!(?<severity>NOTE|TIP|IMPORTANT|WARNING|CAUTION)\]\s*\n>\s*(?<message>.+)(?:\s*\n>\s*.*?)*?$/gim
+  /^\s*>\s*\[!(?<severity>NOTE|TIP|IMPORTANT|WARNING|CAUTION)\]\s*\n>\s*(?<message>.+)(?:\s*\n>\s*.*?)*?$/gim;


To fix the issue, we need to rewrite the regular expression to eliminate the ambiguity caused by .*? within the repetition pattern. Specifically, we can replace .*? with a more specific sub-expression that avoids ambiguity. For example, instead of matching any character lazily, we can match characters that are not part of the repetition pattern (\n>). This ensures that the regular expression does not backtrack excessively.

The updated regular expression will replace .*? with [^>\n]*, which matches any sequence of characters that are not > or newline. This change removes the ambiguity and improves performance while preserving the intended functionality.

packages/core/src/changelog.test.ts

packages/core/src/dotenv.ts

-                }
+        // Enclose in quotes if the value contains newlines or quotes, and escape quotes
+        if (value.includes("\n") || value.includes('"')) {
+          value = value.replace(/"/g, '\\"'); // Escape existing quotes


To fix the issue, the value.replace operation should be updated to escape both double quotes and backslashes. This can be achieved by chaining two replace calls or using a single regular expression that matches both characters. The best approach is to use a single regular expression with a global flag to ensure all occurrences are replaced. This ensures that the output is properly escaped and consistent with expected dotenv formatting.

Changes will be made to the dotEnvStringify function in the file packages/core/src/dotenv.ts. Specifically, the line value.replace(/"/g, '\\"') will be replaced with value.replace(/["\\]/g, '\\$&'), which escapes both double quotes and backslashes.

packages/core/src/fence.ts

-
-        return text
+    if (/file=\w+\.\w+/.test(label)) {
+      const m = /^\s*\`{3,}\w*\r?\n((.|\s)*)\r?\n\`{3,}\s*$/.exec(text);


To fix the issue, we need to rewrite the regular expression to remove the ambiguity caused by (.|\s)*. Instead of using (.|\s)*, we can use a more specific pattern that matches any character except backticks (```) directly. This avoids the ambiguity and ensures efficient matching.

The updated regular expression will replace (.|\s)* with [^\]*`, which matches zero or more characters that are not backticks. This change preserves the original functionality while eliminating the risk of exponential backtracking.

The fix will be applied to line 165 in the normalize function within the file packages/core/src/fence.ts.

packages/core/src/markdown.ts

packages/core/src/prompty.ts

-                ? `defAudio("${c.input_audio}")`
-                : `unknown message`
+  const renderJinja = (content: string) =>
+    `$\`${content.replace(/`/g, "\\`")}\`${/\{(%|\{)/.test(content) ? `.jinja(env.vars)` : ""}`;


To fix the issue, the content.replace operation should be updated to escape backslashes in addition to backticks. This can be achieved by first replacing all backslashes (\) with double backslashes (\\) and then replacing backticks (\``) with escaped backticks (\``). The order of these replacements is important to avoid double-escaping backslashes introduced during the first replacement.

The updated code will use a regular expression with the global flag (g) to ensure all occurrences of the characters are replaced. This approach ensures that the string is properly sanitized for use in the intended context.

packages/core/src/unwrappers.ts

+    .filter((s) => s !== undefined && s !== null)
+    .map((l) => (l === "*" ? ".*?" : l.replace(/[^a-z0-9_]/gi, "")))
+    .join("|");
+  const startRx = new RegExp(`^[\r\n\s]*(\`{3,})(${lg})\s*\r?\n`, "i");


To fix the issue, the escape sequence \s in the string literal should be properly escaped as \\s. This ensures that the backslash is preserved when the string is converted into a regular expression, and the intended meaning of \s as a whitespace character is retained.

The fix involves updating the regular expression string on line 21 to use \\s instead of \s. Similarly, the regular expression on line 25 also contains \s and should be updated to \\s for consistency and correctness.

packages/core/src/unwrappers.ts

+    .filter((s) => s !== undefined && s !== null)
+    .map((l) => (l === "*" ? ".*?" : l.replace(/[^a-z0-9_]/gi, "")))
+    .join("|");
+  const startRx = new RegExp(`^[\r\n\s]*(\`{3,})(${lg})\s*\r?\n`, "i");


To fix the issue, the \s escape sequence in the string literal should be replaced with \\s. This ensures that the backslash is correctly interpreted as part of the regular expression when the string is passed to the RegExp constructor. Similarly, any other escape sequences in the regular expression should be reviewed and corrected if necessary.

The specific changes are:

Update the startRx regular expression on line 21 to use \\s instead of \s.

Update the endRx regular expression on line 25 to use \\s instead of \s.

packages/core/src/unwrappers.ts

+  const mstart = startRx.exec(text);
+  if (mstart) {
+    const n = mstart[1].length;
+    const endRx = new RegExp(`\r?\n\`{${n},${n}}[\r\n\s]*$`, "i");


packages/core/src/annotations.ts

-    }
+  // Match against TypeScript, GitHub, and Azure DevOps regex patterns.
+  for (const rx of ANNOTATIONS_RX) {
+    for (const m of text.matchAll(rx)) addAnnotation(m);


packages/core/src/annotations.ts

+  return text?.replace(GITHUB_MARKDOWN_WARNINGS_RX, (s, ...args) => {
+    const groups = args.at(-1);
+    const { severity, message, suggestion } = groups;
+    const sev = SEV_MAP[severity?.toLowerCase()] ?? "info";
+    const d = deleteUndefinedValues({
+      severity: sev,
+      filename: "",
+      range: [
+        [0, 0], // Start of range, 0-based index
+        [0, Number.MAX_VALUE], // End of range, max value for columns
+      ],
+      code: "",
+      message,
+      suggestion,
+    }) satisfies Diagnostic;
+    return convertAnnotationToItem(d);
+  });


packages/core/src/annotations.ts

+  return text
+    ?.replace(
+      GITHUB_ANNOTATIONS_RX,
+      (
+        _,
+        severity,
+        file,
+        line,
+        endLine,
+        __,
+        code,
+        message,
+        suggestion,
+      ) => `> [!${severities[severity] || severity}]
 > ${message} (${file}#L${line} ${code || ""})
 ${suggestion ? `\`\`\`suggestion\n${suggestion}\n\`\`\`\n` : ""}
-`
-        )
-        ?.replace(
-            AZURE_DEVOPS_ANNOTATIONS_RX,
-            (_, severity, file, line, __, code, message) => {
-                return `> [!${severities[severity] || severity}] ${message}
+`,
+    )


packages/core/src/changelog.ts

packages/core/src/cleaners.ts

-    return text
-        ?.replace(/\[([^\]]+)\]\([^)]+\)/g, (m, n) => n)
-        ?.replace(/<\/?([^>]+)>/g, "")
+  return text?.replace(/\[([^\]]+)\]\([^)]+\)/g, (m, n) => n)?.replace(/<\/?([^>]+)>/g, "");


packages/core/test/changelog.test.ts

+    const source = `ChangeLog:1@email_validator.py
 Description: Implement a function to validate both email addresses and URLs.
 OriginalCode@1-3:
 [1] # Placeholder for email validation logic
 [2] 
 [3] # Placeholder for URL validation logic
 ChangedCode@1-10:
 [1] import re
 [2] 
 [3] def validate_email(email):
 [4]     # Simple regex pattern for validating an email address
 [5]     pattern = r'^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$'
 [6]     return re.match(pattern, email) is not None
 [7] 
 [8] def validate_url(url):
 [9]     # Simple regex pattern for validating a URL
 [10]     pattern = r'^https?:\/\/[\w.-]+\.[a-zA-Z]{2,}.*$'
 [11]     return re.match(pattern, url) is not None
 [12] 
 [13] def validate_email_and_url(email, url):
 [14]     return validate_email(email) and validate_url(url)
-`
-        const res = parseChangeLogs(source)
-        assert.equal(res.length, 1)
-        assert.equal(res[0].filename, "email_validator.py")
-    })
+`;


To fix the issue, ensure that the escape sequence \. is used correctly in the context of the regular expression or string literal. If the goal is to match a literal dot, ensure that the backslash is properly escaped when using a string literal (e.g., '\\.'). If the escape sequence is unnecessary, remove the backslash to avoid confusion and potential errors.

In this case, we will review the relevant code and adjust the escape sequence as needed to ensure the regular expression behaves as intended.

packages/core/test/githubclient.test.ts

+      "https://github.com/user-attachments/assets/a6e1935a-868e-4cca-9531-ad0ccdb9eace",
+    );
+    assert(resolved);
+    assert(resolved.includes("githubusercontent.com"));


To fix the problem, replace the substring check with a proper host check. Specifically, parse the resolved URL using the URL constructor and check that the host property is exactly raw.githubusercontent.com or ends with .githubusercontent.com. This ensures that only valid GitHub asset hosts are accepted, and not arbitrary hosts containing the substring. The change should be made in the test block at line 123 in packages/core/test/githubclient.test.ts. No new methods are needed, but the test assertion should be updated to use the parsed host.

packages/core/test/githubclient.test.ts

+      "https://github.com/user-attachments/assets/f7881bef-931d-4f76-8f63-b4d12b1f021e",
+    );
+    console.log(resolved);
+    assert(resolved.includes("githubusercontent.com"));


To fix the problem, the test should parse the returned URL and check that its host is exactly githubusercontent.com or matches a whitelist of allowed hosts. This avoids the risk of matching substrings in the path, query, or a malicious host. The best way to do this is to use the standard URL class to parse the URL and then assert that the host property matches the expected value. Specifically, in packages/core/test/githubclient.test.ts, lines 130 and 123 should be changed to parse the URL and check the host, rather than using includes. No new dependencies are needed, as the URL class is available in Node.js.

packages/runtime/src/nodehost.ts

+      value = { model: value, source };
+    }
+    const aliases = this._modelAliases[source];
+    const c = aliases[id] || (aliases[id] = { source });


packages/runtime/src/nodehost.ts

+    const c = aliases[id] || (aliases[id] = { source });
+    if (value === undefined || value.model === id) {
+      dbg(`alias ${id}: deleting (source: ${source})`);
+      delete aliases[id];


packages/cli/src/server.ts

packages/core/src/mdstringify.ts

+    } else if (typeof obj === "string") {
+      if (quoteValues) {
+        if (obj.includes("\n")) return fenceMD(obj);
+        return `\`${obj.replace(/`/g, "\\`")}\``;


To fix the issue, we need to ensure that backslashes are escaped before escaping backticks. This can be achieved by chaining two replace calls: the first to escape backslashes (\) and the second to escape backticks (```). This ensures that all occurrences of these characters are properly escaped.

The fix will involve modifying the replace call on line 56 to include an additional step for escaping backslashes. Specifically:

Replace backslashes (\) with double backslashes (\\).

Replace backticks (\``) with escaped backticks (\``).

This change will ensure that the string is correctly escaped for Markdown rendering.

packages/core/src/mdstringify.ts

+        if (obj.includes("\n")) return fenceMD(obj);
+        return `\`${obj.replace(/`/g, "\\`")}\``;
+      } else return obj;
+    } else return quoteValues ? `\`${String(obj).replace(/`/g, "\\`")}\`` : String(obj);


To fix the issue, we need to ensure that backslashes are properly escaped in addition to backticks. This can be achieved by first replacing all backslashes (\) with double backslashes (\\) and then replacing backticks () with escaped backticks (``). This order is important to avoid inadvertently escaping the backslashes added during the first replacement.

The fix involves modifying the replace logic on line 58 to handle both backslashes and backticks. We will use a regular expression with the g flag to ensure all occurrences are replaced.

packages/core/src/env.ts

+      return b;
+    }
+    const res =
+      trimTrailingSlash(b.replace(/\/openai\/deployments.*$/, "")) + `/openai/deployments`;


…#1715) - Introduced `GITHUB_MODELS_ORG` environment variable to specify an organization for inference. - Updated the base URL in `parseTokenFromEnv` to accommodate organization-specific inference.

…ance (#1717)

…nd updating processing logic

* Remove GitHub short links support from MdAstOptions and related imports * Refactor parse functions to include return types and add remarkDetails plugin for HTML details support * Add remarkDetails plugin for parsing HTML details elements and enhance related functionality * Fix summary assertion in details element tests and adjust markdown content parsing expectations * Fix formatting issues in remarkDetails tests and add a new test for handling lists in details elements * Add tests for parsing and stringifying HTML details elements with various content types * Remove unused remark-github dependency from pnpm-lock.yaml

* Add support for MCP model provider and enhance debugging capabilities * Add MCP Client Sampling configuration to language model providers * Add model specification to emojifier script * Refactor MCP server initialization and enhance client sampling registration * Fix resource handling in MCP server and update resource manager methods * Implement MCP sampling language model and refactor MCP server client registration * Add parent language model support to MCP server and worker * Refactor MCP server and worker to enhance message handling and support sampling language model * Enhance debug logging for chatCompletion messages in MCP server and worker * Refactor message handling in createWorkerLanguageModel for improved clarity and maintainability

… improvements

…structions path

* Initial plan * Initial analysis and planning for frontmatter parameter interpolation fix Co-authored-by: pelikhan <[email protected]> * Fix frontmatter parameter interpolation in mustache.ts Co-authored-by: pelikhan <[email protected]> * Enhance frontmatter parameter support for prompty format Co-authored-by: pelikhan <[email protected]> * genai: /docs [skip ci] --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pelikhan <[email protected]>

…) (#1903) * Initial plan * Fix Windows path handling in VSCode extension context menu Co-authored-by: pelikhan <[email protected]> * Add tests for Windows path handling fix Co-authored-by: pelikhan <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pelikhan <[email protected]> Co-authored-by: Peli de Halleux <[email protected]>

github-actions · 2025-08-22T21:04:18Z

Investigator report

Context collection

AI Analysis

AI-generated content by gai may be incorrect. Use reactions to eval.

…ing (#1906)

…on (#1915) * Initial plan * Fix env.files not populated for folder selection in VS Code Co-authored-by: pelikhan <[email protected]> * Fix haiku generation to handle multiple files in environment variable * Refactor type annotations and improve file URI handling in runScriptInternal and VSCodeHost --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pelikhan <[email protected]> Co-authored-by: Peli de Halleux <[email protected]>

…for FormData (#1914) * Initial plan * Fix generateImage edit mode content type error by using global.fetch for FormData Co-authored-by: pelikhan <[email protected]> * genai: /docs [skip ci] --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pelikhan <[email protected]> Co-authored-by: Peli de Halleux <[email protected]>

…pic Claude models (#1919) * Initial plan * Add comprehensive AWS Bedrock environment variable support - Add AWS_REGION validation (required) - Support multiple authentication methods: access keys, profiles, Bedrock API keys - Add environment variable definitions to llmsdata.ts - Update documentation with configuration examples - Enhanced error messages for missing credentials Co-authored-by: pelikhan <[email protected]> * Add comprehensive logging for optional Bedrock environment variables - Log session token usage for temporary credentials - Log optional configuration: ANTHROPIC_SMALL_FAST_MODEL_AWS_REGION - Log prompt caching and model override settings - Enhanced debugging visibility for Bedrock configuration Co-authored-by: pelikhan <[email protected]> * genai: /docs [skip ci] --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pelikhan <[email protected]>

)

- Bump esbuild version from 0.25.8 to 0.25.9 in vscode and web packages. - Update modelcontextprotocol/sdk version from 1.17.2 to 1.18.0 in multiple package.json files. - Upgrade turbo version from 2.5.5 to 2.5.6 in pnpm-lock.yaml. - Update zx version from 8.6.0 to 8.8.1 in slides package.json.

…LT_SCRIPT_META environment variable (#1928)

…and .gitignore

…space options destructuring

…improved clarity

…1937)

github-actions bot reviewed May 28, 2025

View reviewed changes

packages/core/src/chat.ts Outdated Show resolved Hide resolved

github-actions bot reviewed May 28, 2025

View reviewed changes

packages/core/src/mcpclient.ts Show resolved Hide resolved

github-actions bot reviewed May 28, 2025

View reviewed changes

packages/core/src/types/prompt_template.d.ts Outdated Show resolved Hide resolved

pelikhan requested a review from bzorn June 2, 2025 21:27

bzorn approved these changes Jun 2, 2025

View reviewed changes

github-advanced-security bot found potential problems Jun 19, 2025

View reviewed changes

github-advanced-security bot found potential problems Jun 21, 2025

View reviewed changes

github-advanced-security bot found potential problems Jun 25, 2025

View reviewed changes

packages/cli/src/server.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jun 27, 2025

View reviewed changes

github-advanced-security bot found potential problems Jul 6, 2025

View reviewed changes

pelikhan and others added 19 commits July 7, 2025 18:12

Add support for organization inference in GitHub Models configuration (…

a39863a

…#1715) - Introduced `GITHUB_MODELS_ORG` environment variable to specify an organization for inference. - Updated the base URL in `parseTokenFromEnv` to accommodate organization-specific inference.

Release 2.2.10

15caa2f

[skip ci] updated version numbers

bfddc7e

Add --no-run-trace option and disable trace configuration for perform…

fa6a6c9

…ance (#1717)

Release 2.2.11

0329883

[skip ci] updated version numbers

6897293

Remark GitHub alerts (#1718)

92570ac

Enhance GitHub alert handling by adding GitHubAlertMarker interface a…

4ddc31e

…nd updating processing logic

Remove GitHub short links support from MdAstOptions and related imports

ee525f1

Release 2.2.12

22a0728

[skip ci] updated version numbers

0c45bdc

Enhance MCP server documentation with sampling support and formatting…

11384c5

… improvements

samples options

5129fde

offline mode

602b91f

Update .gitignore to include .pnpm-store and change GitHub Copilot in…

f833836

…structions path

move prompt to github folder

6ea570a

Add dev-proxy-tools actions to ollama workflow and log output

f758d16

Copilot AI and others added 6 commits August 22, 2025 09:48

Release 2.4.1

078ade9

[skip ci] updated version numbers

b7e2d39

Fix optional chaining for trace property in startServer function

e3df513

Add retry logic for language chat model resolution in VSCode extension

047ec6c

Copilot AI and others added 23 commits August 23, 2025 04:54

Fix CodeQL security vulnerabilities in shell execution and file handl…

66e5c7e

…ing (#1906)

Update parseTokenFromEnv to use environment variable for LITELLM API key

51e5d74

Add support for Claude MCP configuration files in CLI run command (#1923

0881121

)

#1886 (comment) (#1926)

59061be

Release 2.5.0

268c4c5

[skip ci] updated version numbers

0e5c444

Add support for setting default script metadata via GENAISCRIPT_DEFAU…

0be10f2

…LT_SCRIPT_META environment variable (#1928)

fix: format devcontainer.json for improved readability

3c0d828

Merge branch 'dev' of https://github.com/microsoft/genaiscript into dev

94fce23

feat: add gh-aw installation and compilation scripts to package.json …

ea4060b

…and .gitignore

fix: correct curl command in gh-aw:install script

be68fa5

fix: improve debug messages in file writing functions and update work…

5526ea9

…space options destructuring

fix: update debug messages in writeText and appendText functions for …

2acbc2c

…improved clarity

Fix potential null dereference in server.ts when trace is disabled (#…

bd6a2e9

…1937)

default node 24 image

2ff1e73

Add --issue flag to create a GitHub issue with generation output

8658fbe

Merge branch 'dev' of https://github.com/microsoft/genaiscript into dev

0a2536f

Release 2.5.1

9241a57

[skip ci] updated version numbers

04e1884

@@ -51,3 +51,3 @@
                     if (value.includes("\n") || value.includes('"')) {
-                      value = value.replace(/"/g, '\\"'); // Escape existing quotes
+                      value = value.replace(/["\\]/g, '\\$&'); // Escape double quotes and backslashes
                       return `${key}="${value}"`;

@@ -164,3 +164,3 @@
                 if (/file=\w+\.\w+/.test(label)) {
-                  const m = /^\s*\`{3,}\w*\r?\n((.|\s)*)\r?\n\`{3,}\s*$/.exec(text);
+                  const m = /^\s*\`{3,}\w*\r?\n([^\`]*)\r?\n\`{3,}\s*$/.exec(text);
                   if (m) return m[1];

@@ -144,3 +144,3 @@
               const renderJinja = (content: string) =>
-                `$\`${content.replace(/`/g, "\\`")}\`${/\{(%|\{)/.test(content) ? `.jinja(env.vars)` : ""}`;
+                `$\`${content.replace(/\\/g, "\\\\").replace(/`/g, "\\`")}\`${/\{(%|\{)/.test(content) ? `.jinja(env.vars)` : ""}`;
               const renderPart = (c: ChatCompletionContentPart) =>

@@ -120,14 +120,22 @@
                   "https://github.com/user-attachments/assets/a6e1935a-868e-4cca-9531-ad0ccdb9eace",
                 );
                 assert(resolved);
-                assert(resolved.includes("githubusercontent.com"));
+                const parsedHost = new URL(resolved).host;
+                assert(
+                  parsedHost === "raw.githubusercontent.com" ||
+                  parsedHost.endsWith(".githubusercontent.com")
+                );
               });
               test("resolveAssetUrl - mp4", async () => {
                 const resolved = await client.resolveAssetUrl(
                   "https://github.com/user-attachments/assets/f7881bef-931d-4f76-8f63-b4d12b1f021e",
                 );
                 console.log(resolved);
-                assert(resolved.includes("githubusercontent.com"));
+                const parsedHost = new URL(resolved).host;
+                assert(
+                  parsedHost === "raw.githubusercontent.com" ||
+                  parsedHost.endsWith(".githubusercontent.com")
+                );
               });
               test("resolveAssetUrl - image - indirect", async () => {

Dev #1578

Are you sure you want to change the base?

Dev #1578

Uh oh!

Conversation

pelikhan commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 2, 2025

Annotations from the provided diff:

Linter: no-fix-mes

Linter: grumpy-dev

Linter: diagrams

Linter: no-fix-mes

Linter: grumpy-dev

Linter: diagrams

Summary Table (Linter: stats):

Uh oh!

Uh oh!

Check failure

Copilot Autofix

Uh oh!

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Uh oh!

Check failure

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Check failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!