Skip to content

Conversation

@ohmaya
Copy link

@ohmaya ohmaya commented Nov 14, 2025

The 2nd part is for StructuredBuffers instead of for ByteAddressBuffers.

The 2nd part is for StructuredBuffers instead of for ByteAddressBuffers.
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks correct to me.

Can you confirm please, @pow2clk or @V-FEXrt?

Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StructuredBuffers don't have templated Load methods. This is for the syntax:

ByteAddressBuffer Buf;

[numthreads(1,1,1)]
void main() {
    vector<float,8> V = Buf.Load<vector<float,8> >(0);
}

Compiler Explorer

Edit:

For context, the usage for StructuredBuffers is:

StructuredBuffer<vector<float,8> > Buf;

[numthreads(1,1,1)]
void main() {
    vector<float,8> V = Buf.Load(0);
}

Compiler Explorer

Note that the Load method is not templated.

@ohmaya
Copy link
Author

ohmaya commented Nov 15, 2025

Then we can add a "non-" before "templated".

It seems the whole sentence, "N-element vectors are loaded and stored from ByteAddressBuffers using the templated load and store methods with" (twice at the moment), was just copied from the section for ByteAddressBuffer and pasted without modifying every places for StructuredBuffers.

StructuredBuffers uses the non-templated load and store methods.
Adding "subscript operators".

Co-authored-by: Chris B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants