RadioMenuFlyoutItem API review #19
Conversation
* Background context and api notes Added some background context and moved the API Notes section to the IDL * Update active/RadioMenuFlyoutItem/RadioMenuFlyoutItem.md
|
Looks great. I approve. |
| Boolean IsChecked; | ||
|
|
||
| /// Gets or sets the name that specifies which RadioMenuFlyoutItem controls are mutually exclusive | ||
| String GroupName; |
There was a problem hiding this comment.
I assume the GroupName scope is the containing MenuFlyout? Or is it scoped to the MenuFlyoutSubItem if in a subitem?
There was a problem hiding this comment.
It's scoped to siblings in whatever flyout it's in.
There was a problem hiding this comment.
Recommend: Need to update this in the description.
| # API Details | ||
| ````c# | ||
| [webhosthidden] | ||
| unsealed runtimeclass RadioMenuFlyoutItem : Windows.UI.Xaml.Controls.MenuFlyoutItem |
There was a problem hiding this comment.
RadioButton derives from ToggleButton, but RadioMenuFlyoutItem doesn't derive from ToggleMenuFlyoutItem. Intentional?
There was a problem hiding this comment.
We did do that intentionally but I could be convinced otherwise. :)
There was a problem hiding this comment.
Does/should it support ThreeState?
There was a problem hiding this comment.
I don't think it should, that doesn't feel like a compelling scenario inside a context menu.
There was a problem hiding this comment.
Discussion: Based on that, not deriving from ToggleMenuFlyoutItem sounds right.
|
This API was released in WinUI 2.1, so I beleive this PR is no longer necessary to keep active. |
|
Doesn't this still need to be merged into master? @MikeHillberg |
|
I believe this PR was the API board's copy. The PR I had created, that got API board approval, incorporates this feedback and is checked in here: https://github.com/microsoft/microsoft-ui-xaml-specs/tree/master/active/RadioMenuFlyoutItem But I may be confused about this :) |
5 participants
No description provided.