Skip to content

fix: Omnisharp dynamic arguments are not escaped #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Omnisharp dynamic arguments are not escaped #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/multilspy/language_servers/omnisharp/omnisharp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import logging
import os
import pathlib
import shlex
import stat
from contextlib import asynccontextmanager
from typing import AsyncIterator, Iterable
Expand Down Expand Up @@ -71,20 +72,20 @@ def __init__(self, config: MultilspyConfig, logger: MultilspyLogger, repository_

cmd = " ".join(
[
omnisharp_executable_path,
shlex.quote(omnisharp_executable_path),
"-lsp",
"--encoding",
"ascii",
"-z",
"-s",
slnfilename,
shlex.quote(slnfilename),
"--hostPID",
str(os.getpid()),
"DotNet:enablePackageRestore=false",
"--loglevel",
"trace",
"--plugin",
dll_path,
shlex.quote(dll_path),
"FileOptions:SystemExcludeSearchPatterns:0=**/.git",
"FileOptions:SystemExcludeSearchPatterns:1=**/.svn",
"FileOptions:SystemExcludeSearchPatterns:2=**/.hg",
Expand Down