Adding option to remove only containers created by AL-Go. #3983
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to AL-Go issue: microsoft/AL-Go#1675
During the AL-Go CICD workflow, we will purge all containers Business Central containers created via navcontainerhelper, if they have been offline for 3 days (by default).
This scenario can happen if you have containers on a VM as well as self-hosted GitHub runners used for AL-Go, as those runners will purge both the containers created by AL-Go, but also any other BC containers on that VM which might have been creator for other purposes.
This fix allows a new option to the cache param of the Flush function, such that it checks for a AL-Go creator label and only deleted containers with that label. A separate PR on the AL-Go side, will add this label to containers created by AL-Go.