-
Notifications
You must be signed in to change notification settings - Fork 258
Add RunPageScriptingTests parameter and implementation to Run-AlPipeline #4052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ine microsoft#2001 * Pass the parameters as a hashtable to RunPageScriptingTests function so that they can be adjusted later in a non-breaking manner. * do a depper check on bcAuthContext to differ saas envionments from other. * do not check if the container was lef created before running page scripting tests.
freddykristiansen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 questions / comments
| Write-GroupEnd | ||
| } | ||
|
|
||
| if ($createContainer -and !$doNotRunPageScriptingTests -and $pageScriptingTests -and $pageScriptingTestResultsFolder -and $pageScriptingTestResultsFile) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you not check that a container is created when restoring the database in a container?
Else, I assume this could fail with CompilerFolder running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just because you use CompilerFolder doesn't necessarily mean you don't have a container.
That's only the case if you set doNotPublishApps at the same time. But if you set this, doNotRunPageScriptingTests is automatically set to true. That would make it OK again, right?
AppHandling/Run-AlPipeline.ps1
Outdated
| $artifactUrl = "" | ||
| $filesOnly = $false | ||
| if ($bcAuthContext) { | ||
| $IsBcSaaSInfrastructure = $bcAuthContext -and $bcAuthContext -is [Hashtable] -and $bcAuthContext.ContainsKey('scopes') -and $bcAuthContext.scopes -in @('https://api.businesscentral.dynamics.com/', 'https://projectmadeira.com/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs to be projectmadeira.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't entirely sure while development because the context goes to dynamics.com by default.
I have now synchronized it with the logic in Run-TestsInNavContainer.ps1.
fixes AL-Go#2001