Skip to content

Conversation

@ChrisBlankDe
Copy link
Contributor

@ChrisBlankDe ChrisBlankDe commented Nov 19, 2025

  • Pass the parameters as a hashtable to RunPageScriptingTests function so that they can be adjusted later in a non-breaking manner.
  • do a depper check on bcAuthContext to differ saas envionments from other.
  • do not check if the container was lef created before running page scripting tests.

fixes AL-Go#2001

…ine microsoft#2001

* Pass the parameters as a hashtable to RunPageScriptingTests function so that they can be adjusted later in a non-breaking manner.
* do a depper check on bcAuthContext to differ saas envionments from other.
* do not check if the container was lef created before running page scripting tests.
@ChrisBlankDe ChrisBlankDe changed the title Add RunPageScriptingTests parameter and implementation to Run-AlPipeline #2001 Add RunPageScriptingTests parameter and implementation to Run-AlPipeline Nov 19, 2025
@ChrisBlankDe ChrisBlankDe marked this pull request as ready for review November 19, 2025 18:30
@ChrisBlankDe ChrisBlankDe requested a review from a team as a code owner November 19, 2025 18:30
Copy link

@freddykristiansen freddykristiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions / comments

Write-GroupEnd
}

if ($createContainer -and !$doNotRunPageScriptingTests -and $pageScriptingTests -and $pageScriptingTestResultsFolder -and $pageScriptingTestResultsFile) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you not check that a container is created when restoring the database in a container?
Else, I assume this could fail with CompilerFolder running

Copy link
Contributor Author

@ChrisBlankDe ChrisBlankDe Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because you use CompilerFolder doesn't necessarily mean you don't have a container.
That's only the case if you set doNotPublishApps at the same time. But if you set this, doNotRunPageScriptingTests is automatically set to true. That would make it OK again, right?

$artifactUrl = ""
$filesOnly = $false
if ($bcAuthContext) {
$IsBcSaaSInfrastructure = $bcAuthContext -and $bcAuthContext -is [Hashtable] -and $bcAuthContext.ContainsKey('scopes') -and $bcAuthContext.scopes -in @('https://api.businesscentral.dynamics.com/', 'https://projectmadeira.com/')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs to be projectmadeira.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't entirely sure while development because the context goes to dynamics.com by default.
I have now synchronized it with the logic in Run-TestsInNavContainer.ps1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants