Enable free dimension override for graph optimization level 0 #25425
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
The PR enables free dimension override at graph optimization level 0 by extending the transformer registration loop and adding a Default case in the transformer generator.
- Iterate transformers from
DefaultthroughMaxLevelinAddPredefinedTransformers - Introduce special handling to apply free dimension overrides at optimization level 0
- Add a
case TransformerLevel::Defaultbranch inGenerateTransformers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/session/inference_session.cc | Expand transformer loop to include Default and register override even at level 0 |
| core/optimizer/graph_transformer_utils.cc | Add Default case to push FreeDimensionOverrideTransformer |
Comments suppressed due to low confidence (1)
onnxruntime/core/optimizer/graph_transformer_utils.cc:223
- Add or update unit tests to verify that free dimension overrides are applied when the optimization level is
Default.
case TransformerLevel::Default: {
|
Can we add a unit test to validate? There should already be free dimension override tests that we can leverage. |
unit tests added |
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
…oft#25425) Enable free dimension override even when the graph optimization level is 0. If the optimization level is above 0, the override will be applied during level 1 optimization.
…oft#25425) Enable free dimension override even when the graph optimization level is 0. If the optimization level is above 0, the override will be applied during level 1 optimization.
Enable free dimension override even when the graph optimization level is 0.
If the optimization level is above 0, the override will be applied during level 1 optimization.