Add op test for torch.unique_consecutive - #2742
Conversation
Added OpInfo-based test for torch.unique_consecutive operator: - Created sample_inputs_unique_consecutive function in extra_opinfo.py that reuses common_methods_invocations.sample_inputs_unique - Added OpInfo entry for ops.aten.unique_consecutive with integral_types - Added TorchLibOpInfo entry in ops_test_data.py Fixes microsoft#2695
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
=======================================
Coverage 70.09% 70.09%
=======================================
Files 226 226
Lines 27388 27388
Branches 2781 2781
=======================================
Hits 19198 19198
Misses 7234 7234
Partials 956 956 ☔ View full report in Codecov by Sentry. |
|
Thanks - looks like there are some errors |
There was a problem hiding this comment.
Pull request overview
This PR adds OpInfo-based test coverage for the torch.unique_consecutive operator, addressing issue #2695. The test reuses PyTorch's standard test infrastructure and follows the established pattern used by other unique operators in the codebase.
Key changes:
- Added
sample_inputs_unique_consecutivefunction to filter test samples to only includedim=Nonecases (matching implementation limitations) - Added
OpInfoentry forops.aten.unique_consecutivewith integral dtypes configuration - Registered the operator in
TorchLibOpInfoto enable the test
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/function_libs/torch_lib/extra_opinfo.py | Adds sample input generator and OpInfo configuration for unique_consecutive operator |
| tests/function_libs/torch_lib/ops_test_data.py | Registers the operator in TorchLibOpInfo test suite |
|
Thanks — but this OpInfo currently exposes a genuine lowering bug rather than just adding coverage, which is why the matrix is red. For |
|
Since PR #2742 has been inactive, I'd like to pick this up and implement the fix suggested by Justin Chu (@justinchuby). |
Summary
torch.unique_consecutiveoperatorChanges
sample_inputs_unique_consecutivefunction inextra_opinfo.pythat filters samples fromcommon_methods_invocations.sample_inputs_uniqueto only include cases withdim=None(as the implementation has limited dim support)OpInfoentry forops.aten.unique_consecutivewithintegral_typesdtypes (matching the implementation which only supports int32/int64)TorchLibOpInfoentry inops_test_data.pyto enable the testTesting
The test follows the same pattern as other unique operator tests (
_unique,_unique2,unique_dim) and reuses PyTorch's standard test infrastructure.Fixes #2695