-
Notifications
You must be signed in to change notification settings - Fork 4.8k
chore(mcp): introduce browser_run_code #38153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /** | ||
| * Copyright (c) Microsoft Corporation. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import vm from 'vm'; | ||
|
|
||
| import { ManualPromise } from 'playwright-core/lib/utils'; | ||
|
|
||
| import { z } from '../../sdk/bundle'; | ||
| import { defineTabTool } from './tool'; | ||
|
|
||
| const codeSchema = z.object({ | ||
| code: z.string().describe(`Playwright code snippet to run. The snippet should access the \`page\` object to interact with the page. Can make multiple statements. For example: \`await page.getByRole('button', { name: 'Submit' }).click();\``), | ||
| }); | ||
|
|
||
| const runCode = defineTabTool({ | ||
| capability: 'core', | ||
| schema: { | ||
| name: 'browser_run_code', | ||
| title: 'Run Playwright code', | ||
| description: 'Run Playwright code snippet', | ||
| inputSchema: codeSchema, | ||
| type: 'action', | ||
| }, | ||
|
|
||
| handle: async (tab, params, response) => { | ||
| response.setIncludeSnapshot(); | ||
| response.addCode(params.code); | ||
| const __end__ = new ManualPromise<void>(); | ||
| const context = { | ||
| page: tab.page, | ||
| __end__, | ||
| }; | ||
| vm.createContext(context); | ||
| await tab.waitForCompletion(async () => { | ||
| const snippet = `(async () => { | ||
| try { | ||
| ${params.code}; | ||
| __end__.resolve(); | ||
| } catch (e) { | ||
| __end__.reject(e); | ||
| } | ||
| })()`; | ||
| vm.runInContext(snippet, context); | ||
| await __end__; | ||
| }); | ||
| }, | ||
| }); | ||
|
|
||
| export default [ | ||
| runCode, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /** | ||
| * Copyright (c) Microsoft Corporation. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { test, expect } from './fixtures'; | ||
|
|
||
| test('browser_run_code', async ({ client, server }) => { | ||
| server.setContent('/', ` | ||
| <button onclick="console.log('Submit')">Submit</button> | ||
| `, 'text/html'); | ||
| await client.callTool({ | ||
| name: 'browser_navigate', | ||
| arguments: { url: server.PREFIX }, | ||
| }); | ||
|
|
||
| expect(await client.callTool({ | ||
| name: 'browser_run_code', | ||
| arguments: { | ||
| code: 'await page.getByRole("button", { name: "Submit" }).click()', | ||
| }, | ||
| })).toHaveResponse({ | ||
| code: `await page.getByRole(\"button\", { name: \"Submit\" }).click()`, | ||
| consoleMessages: expect.stringContaining('- [LOG] Submit'), | ||
| }); | ||
| }); | ||
|
|
||
| test('browser_run_code block', async ({ client, server }) => { | ||
| server.setContent('/', ` | ||
| <button onclick="console.log('Submit')">Submit</button> | ||
| `, 'text/html'); | ||
| await client.callTool({ | ||
| name: 'browser_navigate', | ||
| arguments: { url: server.PREFIX }, | ||
| }); | ||
|
|
||
| expect(await client.callTool({ | ||
| name: 'browser_run_code', | ||
| arguments: { | ||
| code: 'await page.getByRole("button", { name: "Submit" }).click(); await page.getByRole("button", { name: "Submit" }).click();', | ||
| }, | ||
| })).toHaveResponse({ | ||
| code: expect.stringContaining(`await page.getByRole(\"button\", { name: \"Submit\" }).click()`), | ||
| consoleMessages: expect.stringMatching(/\[LOG\] Submit.*\n.*\[LOG\] Submit/), | ||
| }); | ||
| }); | ||
|
|
||
| test('browser_run_code no-require', async ({ client, server }) => { | ||
| server.setContent('/', ` | ||
| <button onclick="console.log('Submit')">Submit</button> | ||
| `, 'text/html'); | ||
| await client.callTool({ | ||
| name: 'browser_navigate', | ||
| arguments: { url: server.PREFIX }, | ||
| }); | ||
|
|
||
| expect(await client.callTool({ | ||
| name: 'browser_run_code', | ||
| arguments: { | ||
| code: `require('fs');`, | ||
| }, | ||
| })).toHaveResponse({ | ||
| result: expect.stringContaining(`ReferenceError: require is not defined`), | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't protect against getting to the all the internals of playwright and fs access etc, I assume that's expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct