chore(0.79): pick a bunch of fixes #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add contentView initialization and container constraints for macOS - Fix layout issues with the dev loading view on macOS platform - Ensure proper positioning and sizing of the loading message window Fixes microsoft#2706 <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The four fields below are mandatory. --> <!-- This fork of react-native provides React Native for macOS for the community. It also contains some changes that are required for usage internal to Microsoft. We are working on reducing the diff between Facebook's public version of react-native and our microsoft/react-native-macos fork. Long term, we want this fork to only contain macOS concerns and have the other iOS and Android concerns contributed upstream. If you are making a new change then one of the following should be done: - Consider if it is possible to achieve the desired behavior without making a change to microsoft/react-native-macos. Often a change can be made in a layer above in facebook/react-native instead. - Create a corresponding PR against [facebook/react-native](https://github.com/facebook/react-native) **Note:** Ideally you would wait for Facebook feedback before submitting to Microsoft, since we want to ensure that this fork doesn't deviate from upstream. --> ## Summary: <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## Test Plan: <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. --> --------- Co-authored-by: ZJH <>
## Summary: While Microsoft is still far away from dropping support for iOS 18, we want to get a head-start on handling deprecated APIs for the latest OS releases. Silence these deprecated API warnings when making macOS 26, iOS 26, and watchOS 26 our minimums. ## Test Plan: There is no change to actual code.
## Problem The "Lint PR Title" job in the PR workflow was consistently failing on first run with the following error: > Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. After a rerun, the job would usually succeed, but this was annoying and required manual intervention. ## Root Cause The `lint-title` job uses the `microsoft-setup-toolchain` action, which has `cache-npm-dependencies: yarn` enabled by default. This causes the underlying `actions/setup-node` action to attempt to cache yarn directories. However, the `lint-title` job never runs `yarn install` - it only executes `npx @rnx-kit/[email protected]` to validate the PR title. Since the cache paths don't exist when the job runs for the first time (before dependencies are installed), the cache action fails with a validation error. ## Solution Disabled caching for the `lint-title` job by setting `cache-npm-dependencies: ''` in the setup-toolchain step. This is appropriate because: 1. The job doesn't install any dependencies - it only uses `npx` to run a single package 2. Caching provides no benefit for this job 3. This eliminates the cache path validation error ## Testing - Verified the YAML syntax is valid - The change is minimal and only affects the `lint-title` job - Other jobs that need caching remain unchanged Fixes microsoft#2403 <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>"Lint PR Title" PR Job always fails</issue_title> > <issue_description>The job always fails with the following error: > > > Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved. > > After a rerun it usually succeeds. But it's quite annoying, and would be nice to fix. </issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> Fixes microsoft#2721 <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Saadnajmi <[email protected]>
vmoroz
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pick a bunch of fixes from our main branch onto 0.79-stable.
Test Plan:
CI should pass